bug - no longer works with 2d data files

[aaronjridley]

The new get_cut_index function no longer works with 2d data files, such as GITM's 2DMEL files. This used to work.

[aaronjridley]

Can be fixed by making isgrid = True for 2d grids instead of the general False in the call.

[aburrell]

Can you send me one of these files (as small as possible) to add to the unit tests?

[aaronjridley]

This still doesn't work right. I changed my main plotting function so that it changes isgrid to be true for 2d files, which works, but it gives a warning.

Do we have a place where I could put files (and notes, maybe) that we should test on? Do we have a repo for these test files? I don't know if we want them in github, since it could grow....? Thoughts?

[qalshidi]

I think @aburrell idea of a small unit test file in a tests/ directory is the standard way to go. There are unit test packages that rely on such things.

[aburrell]

@aaronjridley the files can be added to tests/test_data through a normal pull request. If there's something specific you can also just attach a file to one of these comments by dragging it into the comment box. That can be useful for something you are not sure should be a part of the normal test suite.