From 8bac9be846ecc118ef8c9e062fc27b6ccafc90be Mon Sep 17 00:00:00 2001
From: TheWitness <copilot@users.noreply.github.com>
Date: Fri, 23 Oct 2026 18:39:14 -0400
Subject: [PATCH 1/2] Replace deprecated get_request_var_request() with
 get_request_var()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 includes/settings.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/includes/settings.php b/includes/settings.php
index f0f8a41..d7ec80e 100644
--- a/includes/settings.php
+++ b/includes/settings.php
@@ -157,7 +157,7 @@ function intropage_user_admin_tab(): void {
 
 	print '<li class="subTab">';
 
-	if (get_request_var_request('tab') == 'intropage_settings_edit') {
+	if (get_request_var('tab') == 'intropage_settings_edit') {
 		print '<a class="tab selected" ';
 	} else {
 		print '<a class="tab" ';
@@ -184,7 +184,7 @@ function intropage_user_group_admin_tab(): void {
 
 	print '<li class="subTab">';
 
-	if (get_request_var_request('tab') == 'intropage_group_settings_edit') {
+	if (get_request_var('tab') == 'intropage_group_settings_edit') {
 		print '<a class="tab selected" ';
 	} else {
 		print '<a class="tab" ';

From 747fa53ab3b42ba4ecd25ff2eec21d36e9da81df Mon Sep 17 00:00:00 2001
From: Thomas Vincent <thomasvincent@gmail.com>
Date: Fri, 23 Oct 2026 20:48:45 -0600
Subject: [PATCH 2/2] test: cover the user admin sub-tab hooks

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
---
 tests/Unit/IntropageUserAdminTabTest.php | 44 ++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 tests/Unit/IntropageUserAdminTabTest.php

diff --git a/tests/Unit/IntropageUserAdminTabTest.php b/tests/Unit/IntropageUserAdminTabTest.php
new file mode 100644
index 0000000..2e86f1b
--- /dev/null
+++ b/tests/Unit/IntropageUserAdminTabTest.php
@@ -0,0 +1,44 @@
+<?php
+/*
+ +-------------------------------------------------------------------------+
+ | Copyright (C) 2004-2026 The Cacti Group                                 |
+ +-------------------------------------------------------------------------+
+ | Cacti: The Complete RRDtool-based Graphing Solution                     |
+ +-------------------------------------------------------------------------+
+*/
+
+/*
+ * Unit coverage for the user_admin_tab and user_group_admin_tab hooks in
+ * includes/settings.php: each prints one sub-tab link that points at the
+ * plugin's edit tab.
+ */
+
+require_once __DIR__ . '/../../includes/settings.php';
+
+it('prints the user admin sub-tab link', function () {
+	global $config;
+
+	$config['url_path'] = '/cacti/';
+
+	ob_start();
+	intropage_user_admin_tab();
+	$html = ob_get_clean();
+
+	expect($html)->toStartWith('<li class="subTab">');
+	expect($html)->toContain('href="/cacti/user_admin.php?action=user_edit&amp;tab=intropage_settings_edit&amp;id="');
+	expect($html)->toContain('>Intropage</a></li>');
+});
+
+it('prints the user group admin sub-tab link', function () {
+	global $config;
+
+	$config['url_path'] = '/cacti/';
+
+	ob_start();
+	intropage_user_group_admin_tab();
+	$html = ob_get_clean();
+
+	expect($html)->toStartWith('<li class="subTab">');
+	expect($html)->toContain('href="/cacti/user_group_admin.php?action=edit&amp;tab=intropage_group_settings_edit&amp;id="');
+	expect($html)->toContain('>Intropage</a></li>');
+});