Skip to content

Commit 8a9cf27

Browse files
committed
Improve form accessibility and required field validation
1 parent 4a9c3f6 commit 8a9cf27

1 file changed

Lines changed: 16 additions & 12 deletions

File tree

Form-Controls/index.html

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,23 @@ <h1>Product Pick</h1>
1313
</header>
1414
<main>
1515
<form>
16-
<label for="name">NAME</label>
17-
<input name="name" id="name" type="text" pattern=".*\S.*\S.*" />
16+
<label for="name">Name</label>
17+
<input name="name" id="name" type="text" pattern=".*\S.*\S.*" required />
1818
<label for="email">Email</label>
19-
<input id="email" type="email" required />
19+
<input id="email" name="email" type="email" required />
2020
<fieldset>
21-
<label id="colour" for="colour">Colour</label>
22-
<input type="radio" name="colour" value="black" required />
23-
<input type="radio" name="colour" value="white" required />
24-
<input type="radio" name="colour" value="red" required />
25-
</fieldset>
26-
<label for="size">SIZE</label>
21+
<legend>T-shirt colour</legend>
22+
<label>
23+
<input type="radio" name="colour" value="black" required />Black
24+
</label>
25+
<label>
26+
<input type="radio" name="colour" value="white" required />White
27+
</label>
28+
<label>
29+
<input type="radio" name="colour" value="red" required />Red
30+
</label>
31+
</fieldset>
32+
<label for="size">Size</label>
2733
<select id="size" name="size" required>
2834
<option value="">choose a size</option>
2935
<option value="XS">XS</option>
@@ -33,13 +39,11 @@ <h1>Product Pick</h1>
3339
<option value="XL">XL</option>
3440
<option value="XXL">XXL</option>
3541
</select>
36-
<label id="submit" for="submit"/label>
3742
<button type="submit">Order T-shirt</button>
3843
</form>
3944
</main>
4045
<footer>
41-
Salah Alsabhi
42-
<p>By HOMEWORK SOLUTION</p>
46+
<p>By Salah Al-Sabhi</p>
4347
</footer>
4448
</body>
4549
</html>

0 commit comments

Comments
 (0)