From e65da064d9b37b831dcd729045c88fa0792d00a7 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Wed, 22 Jul 2026 16:31:45 +0200 Subject: [PATCH 01/12] Use static_cast instead of plain c casts * ACE/ace/SSL/SSL_SOCK_Acceptor.cpp: * ACE/ace/SSL/SSL_SOCK_Stream.inl: --- ACE/ace/SSL/SSL_SOCK_Acceptor.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Stream.inl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp index ea76866855de8..126369fd49e54 100644 --- a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp @@ -130,7 +130,7 @@ ACE_SSL_SOCK_Acceptor::ssl_accept (ACE_SSL_SOCK_Stream &new_stream, { // Must have at least one handle to wait for at this point. ACE_ASSERT (rd_handle.num_set() == 1 || wr_handle.num_set () == 1); - status = ACE::select (int (handle) + 1, + status = ACE::select (static_cast(handle) + 1, &rd_handle, &wr_handle, nullptr, diff --git a/ACE/ace/SSL/SSL_SOCK_Stream.inl b/ACE/ace/SSL/SSL_SOCK_Stream.inl index 619fce516869e..4fa43d06220f4 100644 --- a/ACE/ace/SSL/SSL_SOCK_Stream.inl +++ b/ACE/ace/SSL/SSL_SOCK_Stream.inl @@ -14,7 +14,7 @@ ACE_SSL_SOCK_Stream::set_handle (ACE_HANDLE fd) } else { - (void) ::SSL_set_fd (this->ssl_, (int) fd); + (void) ::SSL_set_fd (this->ssl_, static_cast(fd)); this->ACE_SSL_SOCK::set_handle (fd); this->stream_.set_handle (fd); } From 3c975e2266538ade661ab80b569c9e372e258e5d Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Wed, 22 Jul 2026 16:37:26 +0200 Subject: [PATCH 02/12] Use static_cast * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp: --- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp index b6cae2fe044ab..e6fece4e5bfbb 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp @@ -293,9 +293,9 @@ run_event_loop (u_short port) ACE_Time_Value timeout (ACE_DEFAULT_TIMEOUT); ACE_Handle_Set temp = handle_set; - int maxfd = int(oneway_acceptor.get_handle ()); - if (maxfd < int(twoway_acceptor.get_handle ())) - maxfd = int(twoway_acceptor.get_handle ()); + int maxfd = static_cast(oneway_acceptor.get_handle ()); + if (maxfd < static_cast(twoway_acceptor.get_handle ())) + maxfd = static_cast(twoway_acceptor.get_handle ()); int result = ACE_OS::select (maxfd + 1, (fd_set *) temp, 0, From 033cc6e6ba9484dea3ae8c7ea2d29488f04f5e3a Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Wed, 22 Jul 2026 16:40:03 +0200 Subject: [PATCH 03/12] Use static_cast * ACE/ace/SSL/SSL_SOCK_Connector.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp: --- ACE/ace/SSL/SSL_SOCK_Connector.cpp | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp | 2 +- ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Connector.cpp b/ACE/ace/SSL/SSL_SOCK_Connector.cpp index 19e69a5e25357..b34a4e0826ec2 100644 --- a/ACE/ace/SSL/SSL_SOCK_Connector.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Connector.cpp @@ -152,7 +152,7 @@ ACE_SSL_SOCK_Connector::ssl_connect (ACE_SSL_SOCK_Stream &new_stream, ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (int (handle) + 1, + status = ACE::select (static_cast(handle) + 1, &rd_handle, &wr_handle, nullptr, diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp index e0a0c87b0f9fc..bb15331defefc 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp @@ -553,7 +553,7 @@ Handler_Factory::handle_events () fd_set temp = handles; int result = - ACE_OS::select (int (this->oneway_acceptor_.get_handle ()) + 1, + ACE_OS::select (static_cast(this->oneway_acceptor_.get_handle ()) + 1, (fd_set *) &temp, 0, 0, diff --git a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp index 91e42445763b2..6eb6405fe926f 100644 --- a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp +++ b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp @@ -148,7 +148,7 @@ namespace ACE ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (int (handle) + 1, + status = ACE::select (static_cast(handle) + 1, &rd_handle, &wr_handle, 0, From 398719d1a12dda6708b7c0e9fe71b38732d726d8 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Thu, 23 Jul 2026 09:16:54 +0200 Subject: [PATCH 04/12] Fix type casting in select call for handle --- ACE/ace/SSL/SSL_SOCK_Acceptor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp index 126369fd49e54..322947d722d6d 100644 --- a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp @@ -130,7 +130,7 @@ ACE_SSL_SOCK_Acceptor::ssl_accept (ACE_SSL_SOCK_Stream &new_stream, { // Must have at least one handle to wait for at this point. ACE_ASSERT (rd_handle.num_set() == 1 || wr_handle.num_set () == 1); - status = ACE::select (static_cast(handle) + 1, + status = ACE::select (reinterpret_cast(handle) + 1, &rd_handle, &wr_handle, nullptr, From 525a02ca2e14ce7163564c03738a407f67014ce6 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Thu, 23 Jul 2026 09:19:38 +0200 Subject: [PATCH 05/12] Use reinterpret_cast * ACE/ace/SSL/SSL_SOCK_Connector.cpp: * ACE/ace/SSL/SSL_SOCK_Stream.inl: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp: * ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp: --- ACE/ace/SSL/SSL_SOCK_Connector.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Stream.inl | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp | 6 +++--- ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Connector.cpp b/ACE/ace/SSL/SSL_SOCK_Connector.cpp index b34a4e0826ec2..f453bcd1ea9c6 100644 --- a/ACE/ace/SSL/SSL_SOCK_Connector.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Connector.cpp @@ -152,7 +152,7 @@ ACE_SSL_SOCK_Connector::ssl_connect (ACE_SSL_SOCK_Stream &new_stream, ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (static_cast(handle) + 1, + status = ACE::select (reinterpret_cast(handle) + 1, &rd_handle, &wr_handle, nullptr, diff --git a/ACE/ace/SSL/SSL_SOCK_Stream.inl b/ACE/ace/SSL/SSL_SOCK_Stream.inl index 4fa43d06220f4..4b6e8fe40d370 100644 --- a/ACE/ace/SSL/SSL_SOCK_Stream.inl +++ b/ACE/ace/SSL/SSL_SOCK_Stream.inl @@ -14,7 +14,7 @@ ACE_SSL_SOCK_Stream::set_handle (ACE_HANDLE fd) } else { - (void) ::SSL_set_fd (this->ssl_, static_cast(fd)); + (void) ::SSL_set_fd (this->ssl_, reinterpret_cast(fd)); this->ACE_SSL_SOCK::set_handle (fd); this->stream_.set_handle (fd); } diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp index bb15331defefc..569d7c7de006a 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp @@ -553,7 +553,7 @@ Handler_Factory::handle_events () fd_set temp = handles; int result = - ACE_OS::select (static_cast(this->oneway_acceptor_.get_handle ()) + 1, + ACE_OS::select (reinterpret_cast(this->oneway_acceptor_.get_handle ()) + 1, (fd_set *) &temp, 0, 0, diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp index e6fece4e5bfbb..bc7b03e03591d 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp @@ -293,9 +293,9 @@ run_event_loop (u_short port) ACE_Time_Value timeout (ACE_DEFAULT_TIMEOUT); ACE_Handle_Set temp = handle_set; - int maxfd = static_cast(oneway_acceptor.get_handle ()); - if (maxfd < static_cast(twoway_acceptor.get_handle ())) - maxfd = static_cast(twoway_acceptor.get_handle ()); + int maxfd = reinterpret_cast(oneway_acceptor.get_handle ()); + if (maxfd < reinterpret_cast(twoway_acceptor.get_handle ())) + maxfd = reinterpret_cast(twoway_acceptor.get_handle ()); int result = ACE_OS::select (maxfd + 1, (fd_set *) temp, 0, diff --git a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp index 6eb6405fe926f..ed845652af4e4 100644 --- a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp +++ b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp @@ -148,7 +148,7 @@ namespace ACE ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (static_cast(handle) + 1, + status = ACE::select (reinterpret_cast(handle) + 1, &rd_handle, &wr_handle, 0, From 2aee08caf6d578d29112f08e3f385c4c1291a4eb Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Thu, 23 Jul 2026 15:00:09 +0200 Subject: [PATCH 06/12] Alternative approach to fix compile errors on Windows 64bit * ACE/ace/SSL/SSL_SOCK_Acceptor.cpp: * ACE/ace/SSL/SSL_SOCK_Connector.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp: * ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp: --- ACE/ace/SSL/SSL_SOCK_Acceptor.cpp | 6 +++++- ACE/ace/SSL/SSL_SOCK_Connector.cpp | 6 +++++- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp | 6 +++++- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp | 11 ++++++++--- ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp | 6 +++++- 5 files changed, 28 insertions(+), 7 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp index 322947d722d6d..fcbbae6cb3a11 100644 --- a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp @@ -130,7 +130,11 @@ ACE_SSL_SOCK_Acceptor::ssl_accept (ACE_SSL_SOCK_Stream &new_stream, { // Must have at least one handle to wait for at this point. ACE_ASSERT (rd_handle.num_set() == 1 || wr_handle.num_set () == 1); - status = ACE::select (reinterpret_cast(handle) + 1, + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = int (handle) + 1; +# endif /* ACE_WIN32 */ + status = ACE::select (select_width, &rd_handle, &wr_handle, nullptr, diff --git a/ACE/ace/SSL/SSL_SOCK_Connector.cpp b/ACE/ace/SSL/SSL_SOCK_Connector.cpp index f453bcd1ea9c6..6d47cfb074e25 100644 --- a/ACE/ace/SSL/SSL_SOCK_Connector.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Connector.cpp @@ -152,7 +152,11 @@ ACE_SSL_SOCK_Connector::ssl_connect (ACE_SSL_SOCK_Stream &new_stream, ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (reinterpret_cast(handle) + 1, + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = int (handle) + 1; +# endif /* ACE_WIN32 */ + status = ACE::select (select_width, &rd_handle, &wr_handle, nullptr, diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp index 569d7c7de006a..a9f56fe4c0f86 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp @@ -552,8 +552,12 @@ Handler_Factory::handle_events () ACE_Time_Value timeout (ACE_DEFAULT_TIMEOUT); fd_set temp = handles; + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = this->oneway_acceptor_.get_handle ()) + 1; +# endif /* ACE_WIN32 */ int result = - ACE_OS::select (reinterpret_cast(this->oneway_acceptor_.get_handle ()) + 1, + ACE_OS::select (select_width, (fd_set *) &temp, 0, 0, diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp index bc7b03e03591d..cf16dda3aff11 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp @@ -293,9 +293,14 @@ run_event_loop (u_short port) ACE_Time_Value timeout (ACE_DEFAULT_TIMEOUT); ACE_Handle_Set temp = handle_set; - int maxfd = reinterpret_cast(oneway_acceptor.get_handle ()); - if (maxfd < reinterpret_cast(twoway_acceptor.get_handle ())) - maxfd = reinterpret_cast(twoway_acceptor.get_handle ()); + int maxfd = 0; +#if !defined (ACE_WIN32) + maxfd = (int)oneway_acceptor.get_handle (); + if (maxfd < (int)twoway_acceptor.get_handle ()) + { + maxfd = (int)twoway_acceptor.get_handle (); + } +# endif /* ACE_WIN32 */ int result = ACE_OS::select (maxfd + 1, (fd_set *) temp, 0, diff --git a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp index ed845652af4e4..0fa3a95ab5323 100644 --- a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp +++ b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp @@ -148,7 +148,11 @@ namespace ACE ACE_ASSERT (rd_handle.num_set () == 1 || wr_handle.num_set () == 1); // Block indefinitely if timeout pointer is zero. - status = ACE::select (reinterpret_cast(handle) + 1, + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = int (handle) + 1; +# endif /* ACE_WIN32 */ + status = ACE::select (select_width, &rd_handle, &wr_handle, 0, From 27df1e9d6c4beecdc070cec041dfd1b237a2ce54 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Thu, 23 Jul 2026 15:29:13 +0200 Subject: [PATCH 07/12] More windows fixes * ACE/ace/ACE.cpp: * ACE/ace/SSL/SSL_SOCK_Acceptor.cpp: * ACE/ace/SSL/SSL_SOCK_Stream.cpp: --- ACE/ace/ACE.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Acceptor.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Stream.cpp | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ACE/ace/ACE.cpp b/ACE/ace/ACE.cpp index 5d0cc449cd6d3..614fa220ad2f7 100644 --- a/ACE/ace/ACE.cpp +++ b/ACE/ace/ACE.cpp @@ -2206,7 +2206,7 @@ ACE::handle_ready (ACE_HANDLE handle, int select_width = 0; #if !defined (ACE_WIN32) select_width = int (handle) + 1; -# endif /* ACE_WIN32 */ +#endif /* ACE_WIN32 */ int result = ACE_OS::select (select_width, read_ready ? handle_set.fdset () : 0, // read_fds. write_ready ? handle_set.fdset () : 0, // write_fds. diff --git a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp index fcbbae6cb3a11..e42e162859e45 100644 --- a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp @@ -133,7 +133,7 @@ ACE_SSL_SOCK_Acceptor::ssl_accept (ACE_SSL_SOCK_Stream &new_stream, int select_width = 0; #if !defined (ACE_WIN32) select_width = int (handle) + 1; -# endif /* ACE_WIN32 */ +#endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, &wr_handle, diff --git a/ACE/ace/SSL/SSL_SOCK_Stream.cpp b/ACE/ace/SSL/SSL_SOCK_Stream.cpp index f242f548d09a9..949d3f372cbb9 100644 --- a/ACE/ace/SSL/SSL_SOCK_Stream.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Stream.cpp @@ -127,9 +127,14 @@ ACE_SSL_SOCK_Stream::recvv (iovec *io_vec, io_vec->iov_base = nullptr; + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = int (this->get_handle ()) + 1; +#endif /* ACE_WIN32 */ + // Check the status of the current socket. switch ( - ACE_OS::select (int (this->get_handle ()) + 1, + ACE_OS::select (select_width, handle_set, nullptr, nullptr, From 7c2735e8e5c4fb892786b83187048114a0481535 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 24 Jul 2026 14:50:18 +0200 Subject: [PATCH 08/12] Updated casts for windows * ACE/ace/SSL/SSL_SOCK_Connector.cpp: * ACE/ace/SSL/SSL_SOCK_Stream.inl: * ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp: * ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp: * ACE/examples/C++NPv2/TPC_Logging_Server.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp: --- ACE/ace/SSL/SSL_SOCK_Connector.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Stream.inl | 6 +++++- ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp | 3 +-- ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp | 2 +- ACE/examples/C++NPv2/TPC_Logging_Server.cpp | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp | 2 +- ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp | 2 +- 7 files changed, 11 insertions(+), 8 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Connector.cpp b/ACE/ace/SSL/SSL_SOCK_Connector.cpp index 6d47cfb074e25..5c5d0a44a3aca 100644 --- a/ACE/ace/SSL/SSL_SOCK_Connector.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Connector.cpp @@ -155,7 +155,7 @@ ACE_SSL_SOCK_Connector::ssl_connect (ACE_SSL_SOCK_Stream &new_stream, int select_width = 0; #if !defined (ACE_WIN32) select_width = int (handle) + 1; -# endif /* ACE_WIN32 */ +#endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, &wr_handle, diff --git a/ACE/ace/SSL/SSL_SOCK_Stream.inl b/ACE/ace/SSL/SSL_SOCK_Stream.inl index 4b6e8fe40d370..099a8bfaf6f9f 100644 --- a/ACE/ace/SSL/SSL_SOCK_Stream.inl +++ b/ACE/ace/SSL/SSL_SOCK_Stream.inl @@ -14,7 +14,11 @@ ACE_SSL_SOCK_Stream::set_handle (ACE_HANDLE fd) } else { - (void) ::SSL_set_fd (this->ssl_, reinterpret_cast(fd)); +#if defined (ACE_WIN32) + (void) ::SSL_set_fd (this->ssl_, static_cast((intptr_t)fd)); +#else + (void) ::SSL_set_fd (this->ssl_, fd); +#endif this->ACE_SSL_SOCK::set_handle (fd); this->stream_.set_handle (fd); } diff --git a/ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp b/ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp index 2ca3e6e97bf34..134aa6d833e74 100644 --- a/ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp +++ b/ACE/examples/C++NPv2/AC_Client_Logging_Daemon.cpp @@ -348,8 +348,7 @@ int AC_CLD_Connector::connect_svc_handler #if defined (ACE_WIN32) // ACE_WIN32 is the only platform where ACE_HANDLE is not an int. // See ace/config-lite.h for the typedefs. - SSL_set_fd (ssl_, - reinterpret_cast (svc_handler->get_handle ())); + SSL_set_fd (ssl_, static_cast ((intptr_t)svc_handler->get_handle ())); #else SSL_set_fd (ssl_, svc_handler->get_handle ()); #endif /* ACE_WIN32 */ diff --git a/ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp b/ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp index 054aa03f0d284..d03979749678d 100644 --- a/ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp +++ b/ACE/examples/C++NPv2/AIO_Client_Logging_Daemon.cpp @@ -259,7 +259,7 @@ int AIO_CLD_Connector::validate_connection #if defined (ACE_WIN32) // ACE_WIN32 is the only platform where ACE_HANDLE is not an int. // See ace/config-lite.h for the typedefs. - SSL_set_fd (ssl_, reinterpret_cast (result.connect_handle ())); + SSL_set_fd (ssl_, static_cast ((intptr_t)result.connect_handle ())); #else SSL_set_fd (ssl_, result.connect_handle ()); #endif /* ACE_WIN32 */ diff --git a/ACE/examples/C++NPv2/TPC_Logging_Server.cpp b/ACE/examples/C++NPv2/TPC_Logging_Server.cpp index e314a8de33fbf..ff741cb559b57 100644 --- a/ACE/examples/C++NPv2/TPC_Logging_Server.cpp +++ b/ACE/examples/C++NPv2/TPC_Logging_Server.cpp @@ -82,7 +82,7 @@ int TPC_Logging_Acceptor::accept_svc_handler #if defined (ACE_WIN32) // ACE_WIN32 is the only platform where ACE_HANDLE is not an int. // See ace/config-lite.h for the typedefs. - SSL_set_fd (ssl_, reinterpret_cast (sh->get_handle ())); + SSL_set_fd (ssl_, static_cast ((intptr_t)sh->get_handle ())); #else SSL_set_fd (ssl_, sh->get_handle ()); #endif /* ACE_WIN32 */ diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp index a9f56fe4c0f86..fba988e5d6772 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp @@ -555,7 +555,7 @@ Handler_Factory::handle_events () int select_width = 0; #if !defined (ACE_WIN32) select_width = this->oneway_acceptor_.get_handle ()) + 1; -# endif /* ACE_WIN32 */ +#endif /* ACE_WIN32 */ int result = ACE_OS::select (select_width, (fd_set *) &temp, diff --git a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp index 0fa3a95ab5323..a7956a11e55f7 100644 --- a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp +++ b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp @@ -151,7 +151,7 @@ namespace ACE int select_width = 0; #if !defined (ACE_WIN32) select_width = int (handle) + 1; -# endif /* ACE_WIN32 */ +#endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, &wr_handle, From 17e61ea0a0ca183da766868d04f76520237210f8 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 24 Jul 2026 14:53:29 +0200 Subject: [PATCH 09/12] Removed uncessary casts * ACE/ace/ACE.cpp: * ACE/ace/SSL/SSL_SOCK_Acceptor.cpp: * ACE/ace/SSL/SSL_SOCK_Connector.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp: * ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp: --- ACE/ace/ACE.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Acceptor.cpp | 2 +- ACE/ace/SSL/SSL_SOCK_Connector.cpp | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp | 6 +++--- ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ACE/ace/ACE.cpp b/ACE/ace/ACE.cpp index 614fa220ad2f7..4de2e0e09f1cb 100644 --- a/ACE/ace/ACE.cpp +++ b/ACE/ace/ACE.cpp @@ -2205,7 +2205,7 @@ ACE::handle_ready (ACE_HANDLE handle, // Wait for data or for the timeout to elapse. int select_width = 0; #if !defined (ACE_WIN32) - select_width = int (handle) + 1; + select_width = handle + 1; #endif /* ACE_WIN32 */ int result = ACE_OS::select (select_width, read_ready ? handle_set.fdset () : 0, // read_fds. diff --git a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp index e42e162859e45..fb33235e92752 100644 --- a/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Acceptor.cpp @@ -132,7 +132,7 @@ ACE_SSL_SOCK_Acceptor::ssl_accept (ACE_SSL_SOCK_Stream &new_stream, ACE_ASSERT (rd_handle.num_set() == 1 || wr_handle.num_set () == 1); int select_width = 0; #if !defined (ACE_WIN32) - select_width = int (handle) + 1; + select_width = handle + 1; #endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, diff --git a/ACE/ace/SSL/SSL_SOCK_Connector.cpp b/ACE/ace/SSL/SSL_SOCK_Connector.cpp index 5c5d0a44a3aca..924fbe693decf 100644 --- a/ACE/ace/SSL/SSL_SOCK_Connector.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Connector.cpp @@ -154,7 +154,7 @@ ACE_SSL_SOCK_Connector::ssl_connect (ACE_SSL_SOCK_Stream &new_stream, // Block indefinitely if timeout pointer is zero. int select_width = 0; #if !defined (ACE_WIN32) - select_width = int (handle) + 1; + select_width = handle + 1; #endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp index cf16dda3aff11..9065a6fb74fdb 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-simple.cpp @@ -295,10 +295,10 @@ run_event_loop (u_short port) int maxfd = 0; #if !defined (ACE_WIN32) - maxfd = (int)oneway_acceptor.get_handle (); - if (maxfd < (int)twoway_acceptor.get_handle ()) + maxfd = oneway_acceptor.get_handle (); + if (maxfd < twoway_acceptor.get_handle ()) { - maxfd = (int)twoway_acceptor.get_handle (); + maxfd = twoway_acceptor.get_handle (); } # endif /* ACE_WIN32 */ int result = ACE_OS::select (maxfd + 1, diff --git a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp index a7956a11e55f7..dccea02c4d6ba 100644 --- a/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp +++ b/ACE/protocols/ace/INet/SSL_Proxy_Connector.cpp @@ -150,7 +150,7 @@ namespace ACE // Block indefinitely if timeout pointer is zero. int select_width = 0; #if !defined (ACE_WIN32) - select_width = int (handle) + 1; + select_width = handle + 1; #endif /* ACE_WIN32 */ status = ACE::select (select_width, &rd_handle, From 5f76a1f78b3bb46ebae83eefe25e835cd18c0184 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 24 Jul 2026 14:58:18 +0200 Subject: [PATCH 10/12] Reduce casts * ACE/ace/SSL/SSL_SOCK_Stream.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: --- ACE/ace/SSL/SSL_SOCK_Stream.cpp | 2 +- ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ACE/ace/SSL/SSL_SOCK_Stream.cpp b/ACE/ace/SSL/SSL_SOCK_Stream.cpp index 949d3f372cbb9..c9a6a067f7977 100644 --- a/ACE/ace/SSL/SSL_SOCK_Stream.cpp +++ b/ACE/ace/SSL/SSL_SOCK_Stream.cpp @@ -129,7 +129,7 @@ ACE_SSL_SOCK_Stream::recvv (iovec *io_vec, int select_width = 0; #if !defined (ACE_WIN32) - select_width = int (this->get_handle ()) + 1; + select_width = this->get_handle () + 1; #endif /* ACE_WIN32 */ // Check the status of the current socket. diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp index fba988e5d6772..e47b1d912ee1f 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp @@ -554,7 +554,7 @@ Handler_Factory::handle_events () int select_width = 0; #if !defined (ACE_WIN32) - select_width = this->oneway_acceptor_.get_handle ()) + 1; + select_width = this->oneway_acceptor_.get_handle () + 1; #endif /* ACE_WIN32 */ int result = ACE_OS::select (select_width, From ecb1ed394bb6b1000561e8136745c47e09146676 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 24 Jul 2026 15:09:12 +0200 Subject: [PATCH 11/12] Reduce scope variable * ACE/ace/SSL/SSL_Context.cpp: --- ACE/ace/SSL/SSL_Context.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ACE/ace/SSL/SSL_Context.cpp b/ACE/ace/SSL/SSL_Context.cpp index 325c9cd7f6fc8..fa4b89fb2a0ba 100644 --- a/ACE/ace/SSL/SSL_Context.cpp +++ b/ACE/ace/SSL/SSL_Context.cpp @@ -784,7 +784,6 @@ ACE_SSL_Context::dh_params (const char *file_name, { // Swiped from Rescorla's examples and the OpenSSL s_server.c app - DH * ret = nullptr; BIO * bio = nullptr; if ((bio = ::BIO_new_file (this->dh_params_.file_name (), "r")) == nullptr) @@ -793,7 +792,7 @@ ACE_SSL_Context::dh_params (const char *file_name, return -1; } - ret = PEM_read_bio_DHparams (bio, nullptr, nullptr, nullptr); + DH * ret = PEM_read_bio_DHparams (bio, nullptr, nullptr, nullptr); BIO_free (bio); if (ret == nullptr) From 9c53c46bdeb5a1e27c5075cee62274a2e2e5d0f8 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 24 Jul 2026 16:49:52 +0200 Subject: [PATCH 12/12] Another windows cast fix * ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp: --- ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp index 012ac569d993c..9b1caa01d7d20 100644 --- a/ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp +++ b/ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp @@ -328,11 +328,11 @@ run_event_loop (u_short port) ACE_Time_Value timeout (ACE_DEFAULT_TIMEOUT); ACE_Handle_Set temp = handle_set; - int result = ACE_OS::select (int (oneway_acceptor.get_handle ()) + 1, - (fd_set *) temp, - 0, - 0, - timeout); + int select_width = 0; +#if !defined (ACE_WIN32) + select_width = oneway_acceptor.get_handle () + 1; +#endif /* ACE_WIN32 */ + int const result = ACE_OS::select (select_width, (fd_set *) temp, 0, 0, timeout); if (result == -1) ACE_ERROR ((LM_ERROR, "(%P|%t) %p\n",