Migration to version 19.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

Modules to migrate

• base_import_async - By @tishmen - [19.0] [MIG] base_import_async: migrate #841
• queue_job - By @tishmen - [19.0] [MIG] queue_job: migrate + tests #840
• queue_job_batch
• queue_job_cron - By @rven - [19.0] [MIG] queue_job_cron: Migration to 19.0 #925
• queue_job_cron_jobrunner
• queue_job_subscribe
• test_queue_job - By @tishmen - [19.0] [MIG] queue_job: migrate + tests #840
• test_queue_job_batch

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[tishmen]

Hi all - I’ll take care of the 19.0 migration for queue_job (starting there, and time permitting I’ll also look at queue_job_cron and queue_job_batch). I’ll follow the OCA 19.0 migration guidelines and open a first draft PR by the end of this week. If anyone is already working on related submodules, please let me know so I can coordinate.

[tishmen]

Quick update: I’m porting all queue addons to 19.0 (queue_job, queue_job_batch, queue_job_cron, queue_job_cron_jobrunner, queue_job_subscribe, base_import_async). Core migration is done and installs cleanly; I’m now running the test suites and fixing any regressions. I’ll open a PR as soon as the tests are green (most likely tomorrow). If anyone is working in parallel on these modules, please let me know so we can coordinate.

[mostafabarmshory]

Any progress?
I ran into an MRO issue in the test 😢 — it needs more attention to fix.

[tishmen]

@mostafabarmshory can you please post the MRO issue that you have encountered in the appropriate PR. I will take a look as soon as possible.

[mostafabarmshory]

@tishmen
Actually, when the class OdooDocTestCase is enable, I face with MRO issue. I commit it and all things goes well.
By the way, the error raise by running unit tests. See the attachement.

[daemonblade]

In Odoo19, odoo.tools.config does not have misc anymore.

This has implications for queue_job/jobrunner/__init__.py, which uses config.misc around line:20 or so.

[tishmen]

@daemonblade Please comment in the relevant code section on the PR so I can review. Thanks.

[daemonblade]

@tishmen From 19.0 branch, queue_job/jobrunner/__init__.py, lines 9-20:

from odoo.service import server
from odoo.tools import config

try:
    from odoo.addons.server_environment import serv_config

    if serv_config.has_section("queue_job"):
        queue_job_config = serv_config["queue_job"]
    else:
        queue_job_config = {}
except ImportError:
    queue_job_config = config.misc.get("queue_job", {})

The last line's config.misc isn't valid anymore.

[ramiadavid]

Why are there modules in version 18.0 in the 19.0 branch? Is this correct?

[rven]

queue_job_cron -> #925