From 96e69044f9957845e7e8e6084f3d0ebc398d4d65 Mon Sep 17 00:00:00 2001 From: kwy404 Date: Sat, 26 Sep 2026 05:20:09 -0300 Subject: [PATCH] Fix stray `>` before a textarea that directly follows an element printElement prints printOpeningTagPrefix for elements whose content is preserved (pre-like elements such as textarea), but printOpeningTag already prints that prefix through printOpeningTagStart. When the element borrows the previous sibling's closing `>`, it is printed twice, so `` became `>`. Fixes #1288 --- .changeset/textarea-borrowed-closing-tag.md | 5 +++++ packages/prettier-plugin-liquid/src/printer/print/element.ts | 1 - .../src/test/html-element/fixed.liquid | 4 ++++ .../src/test/html-element/index.liquid | 4 ++++ 4 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 .changeset/textarea-borrowed-closing-tag.md diff --git a/.changeset/textarea-borrowed-closing-tag.md b/.changeset/textarea-borrowed-closing-tag.md new file mode 100644 index 000000000..fd6c09adf --- /dev/null +++ b/.changeset/textarea-borrowed-closing-tag.md @@ -0,0 +1,5 @@ +--- +'@shopify/prettier-plugin-liquid': patch +--- + +Fix a stray `>` being printed before a ` +
diff --git a/packages/prettier-plugin-liquid/src/test/html-element/index.liquid b/packages/prettier-plugin-liquid/src/test/html-element/index.liquid index 7836ef8a2..506ae5555 100644 --- a/packages/prettier-plugin-liquid/src/test/html-element/index.liquid +++ b/packages/prettier-plugin-liquid/src/test/html-element/index.liquid @@ -21,3 +21,7 @@ it should borrow the closing span in this situation printWidth: 30  {% render 'icon-arrow' %}   aaaaaaaaaaaaaaaaaaaaaaaa + +it should not print the borrowed closing tag end marker twice before a textarea +
+