From 11b17f9968997326c7121e04321c1e9c29d6ff0b Mon Sep 17 00:00:00 2001 From: priya-sundaram-dev Date: Wed, 9 Sep 2026 09:08:02 +0000 Subject: [PATCH 1/2] docs(skill): make the PR checkbox rule a hard final gate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The requirement to tick at least one checklist box was buried in a prose paragraph, so PR bodies generated straight from the template kept going out with every box empty and algorithms-keeper auto-closed them before a human could read them. Promote the rule to an explicit 'Before you click Create pull request' final gate with a re-read/verify step, and spell out that it applies to every PR (CI, docs, tooling) — tick the boxes that genuinely apply so the body is never all-empty. --- .github/skills/new-pull-request/SKILL.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/skills/new-pull-request/SKILL.md b/.github/skills/new-pull-request/SKILL.md index f9dad15ff233..a90e958ca2c0 100644 --- a/.github/skills/new-pull-request/SKILL.md +++ b/.github/skills/new-pull-request/SKILL.md @@ -19,7 +19,7 @@ hand. A hand-modified `uv.lock` makes the `algorithms-keeper` bot close the pull request as invalid, and even a repo maintainer cannot undo that. Always check at least one Markdown checkbox in the pull request description (the "Describe your change" section), or the -`algorithms-keeper` bot will close the pull request as invalid. Any repo maintainer can undo this if you @mention them on the closed pull request. +`algorithms-keeper` bot will close the pull request as invalid — and it does this *before* a human reads the PR, so a genuinely good change gets closed for a formatting reason. This applies to **every** pull request, including CI, docs, and tooling changes that are not algorithms: tick the boxes that genuinely apply so the body is never submitted with all boxes empty. Any repo maintainer can undo this if you @mention them on the closed pull request, but re-opening is often unreliable, so it is far better to get it right the first time. ### 1. Before contributing / Is this an algorithm? @@ -55,3 +55,15 @@ Always check at least one Markdown checkbox in the pull request description (the - [ ] At least one **Wikipedia (or equivalent) URL** documenting the algorithm. - [ ] Docstring explains what the function does and its parameters/returns. - [ ] No unnecessary third-party dependencies. + +## Before you click "Create pull request" + +This is the final gate. Do not open the pull request until every item here is true: + +- [ ] At least one Markdown checkbox in the PR description is checked. **Verify + this by re-reading the rendered body** — if every box is still `- [ ]`, the + `algorithms-keeper` bot will auto-close the PR before any human sees it. + Check the boxes that genuinely apply to this change; never submit an + all-empty checklist, even for a CI, docs, or tooling PR. +- [ ] The branch is not `master`, and `master` is synced with `upstream/master`. +- [ ] `uv.lock` was not hand-edited. From f05e240060738402e8428a977163f50c39975a20 Mon Sep 17 00:00:00 2001 From: Priya Sundaram Date: Wed, 9 Sep 2026 09:37:48 +0000 Subject: [PATCH 2/2] docs(skill): wrap long line to satisfy MD013 (350-char limit) --- .github/skills/new-pull-request/SKILL.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/skills/new-pull-request/SKILL.md b/.github/skills/new-pull-request/SKILL.md index a90e958ca2c0..ca6a0dda5fb2 100644 --- a/.github/skills/new-pull-request/SKILL.md +++ b/.github/skills/new-pull-request/SKILL.md @@ -19,7 +19,13 @@ hand. A hand-modified `uv.lock` makes the `algorithms-keeper` bot close the pull request as invalid, and even a repo maintainer cannot undo that. Always check at least one Markdown checkbox in the pull request description (the "Describe your change" section), or the -`algorithms-keeper` bot will close the pull request as invalid — and it does this *before* a human reads the PR, so a genuinely good change gets closed for a formatting reason. This applies to **every** pull request, including CI, docs, and tooling changes that are not algorithms: tick the boxes that genuinely apply so the body is never submitted with all boxes empty. Any repo maintainer can undo this if you @mention them on the closed pull request, but re-opening is often unreliable, so it is far better to get it right the first time. +`algorithms-keeper` bot will close the pull request as invalid — and it does +this *before* a human reads the PR, so a genuinely good change gets closed for a +formatting reason. This applies to **every** pull request, including CI, docs, +and tooling changes that are not algorithms: tick the boxes that genuinely apply +so the body is never submitted with all boxes empty. Any repo maintainer can +undo this if you @mention them on the closed pull request, but re-opening is +often unreliable, so it is far better to get it right the first time. ### 1. Before contributing / Is this an algorithm?