You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Continuing the discussion in #7507, here's what has already been decided:
getExpressionInfo should be rewritten to just return an object made from the corresponding wrapper.
getExpressionInfo should be deprecated and replaced with a function that returns an expression wrapper for an expression of unknown class. Maybe we can make Expression constructor return the specific instance? Can we just make the instruction-building functions return expression wrappers? That shouldn't be a breaking change, as expression wrappers can be implicitly converted to Wasm pointers via valueOf (e.g. +expr or expr | 0).
Expression infos and expression wrappers need to be made interchangeable to not make the migration a breaking change.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Continuing the discussion in #7507, here's what has already been decided:
getExpressionInfoshould be rewritten to just return an object made from the corresponding wrapper.getExpressionInfoshould be deprecated and replaced with a function that returns an expression wrapper for an expression of unknown class. Maybe we can makeExpressionconstructor return the specific instance? Can we just make the instruction-building functions return expression wrappers? That shouldn't be a breaking change, as expression wrappers can be implicitly converted to Wasm pointers viavalueOf(e.g.+exprorexpr | 0).Is there something else to add or clarify?
All reactions