kvm: keep the restore volume mapping tests on the rsync path

The incremental NAS backup backport (#13877) makes a restore first ask
qemu-img whether the backup references a parent, and flattens the chain with
qemu-img convert when it does; only a backup without a backing file is
rsynced. The volume mapping tests stubbed runSimpleBashScriptForExitValue to
return 0 for every command, so the probe reported a backing chain, the restore
took the convert path, and the rsync invocations these tests assert on never
happened. Answer the probe with "no backing chain", as the existing restore
tests do, and keep 0 for the other checks.

Author: calvix

plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreBackupCommandWrapperTest.java

@@ -624,7 +624,12 @@ public void testRestoreOfExistingVmMapsBackupsToVolumesByUuid() throws Exception
                 scriptMock.when(() -> Script.getExecutableAbsolutePath(anyString()))
                         .thenAnswer(invocation -> invocation.getArgument(0));
                 scriptMock.when(() -> Script.executeCommandForExitValue(anyLong(), any(String[].class))).thenReturn(0);
-                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString())).thenReturn(0);
+                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString()))
+                        .thenAnswer(invocation -> {
+                            String command = invocation.getArgument(0);
+                            // No backing chain, so the restore takes the rsync path this test asserts on.
+                            return command.contains("backing-filename") ? 1 : 0;
+                        });
                 filesMock.when(() -> Files.deleteIfExists(any(Path.class))).thenReturn(true);
 
                 Answer result = wrapper.execute(command, libvirtComputingResource);
@@ -684,7 +689,12 @@ public void testRestoreOfExistingVmFailsWhenBackedUpVolumeIsNoLongerAttached() t
                 scriptMock.when(() -> Script.getExecutableAbsolutePath(anyString()))
                         .thenAnswer(invocation -> invocation.getArgument(0));
                 scriptMock.when(() -> Script.executeCommandForExitValue(anyLong(), any(String[].class))).thenReturn(0);
-                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString())).thenReturn(0);
+                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString()))
+                        .thenAnswer(invocation -> {
+                            String command = invocation.getArgument(0);
+                            // No backing chain, so the restore takes the rsync path this test asserts on.
+                            return command.contains("backing-filename") ? 1 : 0;
+                        });
                 filesMock.when(() -> Files.deleteIfExists(any(Path.class))).thenReturn(true);
 
                 Answer result = wrapper.execute(command, libvirtComputingResource);
@@ -735,7 +745,12 @@ public void testRestoreIntoNewVolumesFallsBackToDeviceIdOrder() throws Exception
                 scriptMock.when(() -> Script.getExecutableAbsolutePath(anyString()))
                         .thenAnswer(invocation -> invocation.getArgument(0));
                 scriptMock.when(() -> Script.executeCommandForExitValue(anyLong(), any(String[].class))).thenReturn(0);
-                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString())).thenReturn(0);
+                scriptMock.when(() -> Script.runSimpleBashScriptForExitValue(anyString()))
+                        .thenAnswer(invocation -> {
+                            String command = invocation.getArgument(0);
+                            // No backing chain, so the restore takes the rsync path this test asserts on.
+                            return command.contains("backing-filename") ? 1 : 0;
+                        });
                 filesMock.when(() -> Files.deleteIfExists(any(Path.class))).thenReturn(true);
 
                 Answer result = wrapper.execute(command, libvirtComputingResource);