fix(seaweedfs): return updated BucketVO from createBucket instead of stale input

createBucket persisted the new access key, secret key, and bucket URL on a
separately loaded BucketVO but returned the original input Bucket object.
BucketApiServiceImpl.createBucket then set only the state on that original
object and updated it again, overwriting the persisted credentials with the
stale values from the input. Return the updated BucketVO (as the Cloudian
driver does) so the caller persists the correct credentials.

Author: chrislusf

plugins/storage/object/seaweedfs/src/main/java/org/apache/cloudstack/storage/datastore/driver/SeaweedFSObjectStoreDriverImpl.java

@@ -415,7 +415,10 @@ public Bucket createBucket(Bucket bucket, boolean objectLock) {
             AmazonIdentityManagement iamClient = getIAMClient(storeId);
             updateAccountIAMPolicy(iamClient, storeId, accountId, null);
 
-            return bucket;
+            // Return the updated BucketVO (not the stale input bucket) so
+            // BucketApiServiceImpl.createBucket does not overwrite the
+            // persisted credentials with the stale values.
+            return bucketVO;
         } catch (Exception e) {
             logger.error("Post-create bucket record update failed for {}; cleaning up remote bucket", bucketName, e);
             try {