fixes and admin only variant

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

api/src/main/java/org/apache/cloudstack/error/README.md

@@ -102,16 +102,22 @@ matched on by API clients that care about the specific error condition.
 
 `error-messages.json` is a server-side concern; the UI has a separate, independent localization
 path built on the same `errortextkey`. `ui/src/utils/plugins.js`'s `localeErrorUtilPlugin`
-(`$toLocaleError(msg, key, params)`) looks up `key` (the `errortextkey`) in the current locale's
-i18n bundle (`ui/public/locales/<locale>.json`, e.g. `hi.json`, `fr_FR.json`: flat key/value
-maps, same ones used for every other UI string). If a matching entry exists, it's used instead of
-the server-rendered `errortext`, with `{{placeholder}}` tokens substituted from `errormetadata`;
-otherwise it falls back to `errortext` unchanged. See `ui/src/utils/plugins.js:230` for the call
-site (`plugins.js:627` for the implementation).
+(`$toLocaleError(msg, key, params)`, called from both `$pollJob`'s async job failure handling and
+`$notifyError`) looks up `key` (the `errortextkey`) in the current locale's i18n bundle
+(`ui/public/locales/<locale>.json`, e.g. `hi.json`, `fr_FR.json`: flat key/value maps, same ones
+used for every other UI string). If a matching entry exists, it's used instead of the
+server-rendered `errortext`, with `{{placeholder}}` tokens substituted from `errormetadata`;
+otherwise it falls back to `errortext` unchanged.
+
+**Admin variant**: like the server, before trying the base key, `$toLocaleError` first tries
+`<key>.admin` when the current user is a root admin (`roletype === 'Admin'`), falling back to the
+base key if no such entry exists. Only this root-admin case is special-cased, matching
+`error-messages.json`'s own `.admin`-suffix behavior; there's no equivalent variant for resource
+admins, domain admins, or regular users.
 
 Practically: to ship a UI-side translation for a specific error, add a key equal to its
-`errortextkey` to the relevant locale file (e.g. `ui/public/locales/hi.json` for Hindi). No
-server-side change is needed.
+`errortextkey` (optionally suffixed `.admin` for a root-admin-specific variant) to the relevant
+locale file (e.g. `ui/public/locales/hi.json` for Hindi). No server-side change is needed.
 
 ## Global settings
 

ui/src/utils/plugins.js

@@ -138,7 +138,7 @@ export const pollJobPlugin = {
           if (action && action.label) {
             errMessage = i18n.global.t(action.label)
           }
-          var desc = result.jobresult.errortext
+          var desc = this.$toLocaleError(result.jobresult.errortext, result.jobresult.errortextkey, result.jobresult.errormetadata)
           if (name) {
             desc = `(${name}) ${desc}`
           }
@@ -628,7 +628,17 @@ export const localeErrorUtilPlugin = {
       if (!key) {
         return msg
       }
-      let localeMsg = i18n.global.t(key)
+      let localeMsg
+      if (!key.endsWith('.admin') && store.getters.userInfo?.roletype === 'Admin') {
+        const adminKey = key + '.admin'
+        const adminMsg = i18n.global.t(adminKey)
+        if (adminMsg && adminMsg !== adminKey) {
+          localeMsg = adminMsg
+        }
+      }
+      if (!localeMsg) {
+        localeMsg = i18n.global.t(key)
+      }
       if (!localeMsg || localeMsg === key) {
         return msg
       }