diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 625eadcbc6..e7d4f8030c 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -20,7 +20,7 @@ updates: schedule: interval: "quarterly" ignore: - - dependency-name: org.jboss.narayana.jta:narayana-jta + - dependency-name: org.jboss.narayana.jta:narayana-jta-jakarta versions: # require Java 11 - ">= 5.13.0" diff --git a/pom.xml b/pom.xml index b7aaeb5e7c..a1456d5e2a 100644 --- a/pom.xml +++ b/pom.xml @@ -83,7 +83,19 @@ jakarta.transaction jakarta.transaction-api - 1.3.3 + 2.0.1 + + + jakarta.enterprise + jakarta.enterprise.cdi-api + 4.1.0 + provided + + + jakarta.interceptor + jakarta.interceptor-api + 2.2.0 + provided @@ -100,10 +112,11 @@ - org.apache.geronimo.modules + org.apache.geronimo.components geronimo-transaction - 2.2.1 + 3.1.5 test + jakarta org.junit.jupiter @@ -130,11 +143,17 @@ org.jboss.narayana.jta - narayana-jta + narayana-jta-jakarta 5.12.7.Final test + + jakarta.el + jakarta.el-api + 5.0.1 + test + org.jboss jboss-transaction-spi diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index ab7ebd73db..b5c993ce68 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -116,7 +116,7 @@ - + diff --git a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java index 05bbbdce21..f361052e69 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java @@ -20,8 +20,9 @@ import javax.sql.DataSource; import javax.sql.XADataSource; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; + +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; import org.apache.commons.dbcp2.BasicDataSource; import org.apache.commons.dbcp2.ConnectionFactory; diff --git a/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java index ffe03db7b2..a2cbbf8322 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java @@ -25,10 +25,11 @@ import javax.sql.PooledConnection; import javax.sql.XAConnection; import javax.sql.XADataSource; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAResource; +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; + import org.apache.commons.dbcp2.Utils; /** diff --git a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java index 25bc0d805a..2ff80d6732 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java @@ -20,12 +20,13 @@ import java.sql.SQLException; import java.util.Objects; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAException; import javax.transaction.xa.XAResource; import javax.transaction.xa.Xid; +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; + import org.apache.commons.dbcp2.ConnectionFactory; /** diff --git a/src/main/java/org/apache/commons/dbcp2/managed/SynchronizationAdapter.java b/src/main/java/org/apache/commons/dbcp2/managed/SynchronizationAdapter.java index 4b56d9073e..d571669f2e 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/SynchronizationAdapter.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/SynchronizationAdapter.java @@ -16,7 +16,7 @@ */ package org.apache.commons.dbcp2.managed; -import javax.transaction.Synchronization; +import jakarta.transaction.Synchronization; /** * Implements {@link Synchronization} for subclasses. diff --git a/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java b/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java index 7996ad8698..13c8cea584 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java @@ -21,14 +21,15 @@ import java.sql.SQLException; import java.util.Objects; -import javax.transaction.RollbackException; -import javax.transaction.Status; -import javax.transaction.Synchronization; -import javax.transaction.SystemException; -import javax.transaction.Transaction; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAResource; +import jakarta.transaction.RollbackException; +import jakarta.transaction.Status; +import jakarta.transaction.Synchronization; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionSynchronizationRegistry; + /** * TransactionContext represents the association between a single XAConnectionFactory and a Transaction. This context * contains a single shared connection which should be used by all ManagedConnections for the XAConnectionFactory, the diff --git a/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java b/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java index a3b218d1c5..98ec383b94 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java @@ -22,12 +22,13 @@ import java.util.Objects; import java.util.WeakHashMap; -import javax.transaction.SystemException; -import javax.transaction.Transaction; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAResource; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; + import org.apache.commons.dbcp2.DelegatingConnection; /** diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java b/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java index fd435387cb..e707a78602 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java @@ -28,10 +28,11 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.sql.SQLException; import javax.sql.XADataSource; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAException; +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; + import org.apache.commons.dbcp2.BasicDataSource; import org.apache.commons.dbcp2.TestBasicDataSource; import org.apache.geronimo.transaction.manager.TransactionManagerImpl; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java b/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java index 3cc35425c7..30e849ac89 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java @@ -28,8 +28,8 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.sql.Timestamp; import java.time.Duration; -import javax.transaction.RollbackException; -import javax.transaction.Status; +import jakarta.transaction.RollbackException; +import jakarta.transaction.Status; import org.apache.commons.dbcp2.Utils; import org.junit.jupiter.api.AfterEach; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java index 4715bbcf5d..1ecf34655f 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java @@ -26,15 +26,16 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.time.Duration; import java.util.Properties; -import javax.transaction.HeuristicMixedException; -import javax.transaction.HeuristicRollbackException; -import javax.transaction.RollbackException; -import javax.transaction.Synchronization; -import javax.transaction.SystemException; -import javax.transaction.Transaction; -import javax.transaction.TransactionManager; import javax.transaction.xa.XAResource; +import jakarta.transaction.HeuristicMixedException; +import jakarta.transaction.HeuristicRollbackException; +import jakarta.transaction.RollbackException; +import jakarta.transaction.Synchronization; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionManager; + import org.apache.commons.dbcp2.ConnectionFactory; import org.apache.commons.dbcp2.Constants; import org.apache.commons.dbcp2.DriverConnectionFactory; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnectionCachedState.java b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnectionCachedState.java index d32c7c1210..57080f284b 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnectionCachedState.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnectionCachedState.java @@ -25,9 +25,10 @@ import java.util.List; import java.util.Properties; -import javax.transaction.TransactionManager; import javax.transaction.xa.XAException; +import jakarta.transaction.TransactionManager; + import org.apache.commons.dbcp2.ConnectionFactory; import org.apache.commons.dbcp2.Constants; import org.apache.commons.dbcp2.DriverConnectionFactory; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java index 3d161e04e9..781261c455 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java @@ -28,7 +28,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.sql.Connection; import java.util.Properties; -import javax.transaction.TransactionManager; +import jakarta.transaction.TransactionManager; import org.apache.commons.dbcp2.ConnectionFactory; import org.apache.commons.dbcp2.Constants; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java index 700ed27c12..03a472105f 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java @@ -34,8 +34,8 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.sql.SQLException; import java.sql.Statement; -import javax.transaction.Synchronization; -import javax.transaction.Transaction; +import jakarta.transaction.Synchronization; +import jakarta.transaction.Transaction; import org.apache.commons.dbcp2.DelegatingConnection; import org.junit.jupiter.api.AfterEach; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestPoolableManagedConnection.java b/src/test/java/org/apache/commons/dbcp2/managed/TestPoolableManagedConnection.java index 929acc5700..fd87a1cf11 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestPoolableManagedConnection.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestPoolableManagedConnection.java @@ -27,7 +27,7 @@ import java.time.Duration; import java.util.Properties; -import javax.transaction.TransactionManager; +import jakarta.transaction.TransactionManager; import org.apache.commons.dbcp2.ConnectionFactory; import org.apache.commons.dbcp2.Constants; diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java b/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java index aeee44b269..a2c4dc99f1 100644 --- a/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java +++ b/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java @@ -33,15 +33,16 @@ Licensed to the Apache Software Foundation (ASF) under one or more import javax.sql.XAConnection; import javax.sql.XADataSource; -import javax.transaction.NotSupportedException; -import javax.transaction.RollbackException; -import javax.transaction.Synchronization; -import javax.transaction.SystemException; -import javax.transaction.Transaction; -import javax.transaction.TransactionManager; -import javax.transaction.TransactionSynchronizationRegistry; import javax.transaction.xa.XAResource; +import jakarta.transaction.NotSupportedException; +import jakarta.transaction.RollbackException; +import jakarta.transaction.Synchronization; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionManager; +import jakarta.transaction.TransactionSynchronizationRegistry; + import org.apache.commons.dbcp2.BasicDataSource; import org.apache.commons.dbcp2.DelegatingConnection; import org.apache.commons.dbcp2.PoolableConnection; diff --git a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java index d11f0d7d35..ff09547c75 100644 --- a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java +++ b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java @@ -17,14 +17,15 @@ package org.apache.commons.dbcp2.transaction; -import javax.transaction.HeuristicMixedException; -import javax.transaction.HeuristicRollbackException; -import javax.transaction.RollbackException; -import javax.transaction.Synchronization; -import javax.transaction.SystemException; -import javax.transaction.Transaction; import javax.transaction.xa.XAResource; +import jakarta.transaction.HeuristicMixedException; +import jakarta.transaction.HeuristicRollbackException; +import jakarta.transaction.RollbackException; +import jakarta.transaction.Synchronization; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; + /** * A Transaction adapter. */ diff --git a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java index 0e1c079771..7e26a36d23 100644 --- a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java +++ b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java @@ -17,14 +17,14 @@ package org.apache.commons.dbcp2.transaction; -import javax.transaction.HeuristicMixedException; -import javax.transaction.HeuristicRollbackException; -import javax.transaction.InvalidTransactionException; -import javax.transaction.NotSupportedException; -import javax.transaction.RollbackException; -import javax.transaction.SystemException; -import javax.transaction.Transaction; -import javax.transaction.TransactionManager; +import jakarta.transaction.HeuristicMixedException; +import jakarta.transaction.HeuristicRollbackException; +import jakarta.transaction.InvalidTransactionException; +import jakarta.transaction.NotSupportedException; +import jakarta.transaction.RollbackException; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionManager; /** * A TransactionManager adapter. diff --git a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java index 34b6a41a2f..71c6fc14c9 100644 --- a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java +++ b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java @@ -17,8 +17,8 @@ package org.apache.commons.dbcp2.transaction; -import javax.transaction.Synchronization; -import javax.transaction.TransactionSynchronizationRegistry; +import jakarta.transaction.Synchronization; +import jakarta.transaction.TransactionSynchronizationRegistry; /** * A TransactionSynchronizationRegistry adapter.