Does not appear to work with latest Gravity Forms

[jonathan-fielding]

Hi

Trying to use this with latest version of Gravity forms, enabled on form level but it isn't doing anything

Thanks

Jonathan

[bhays]

I just tried to get it working on the latest Gravity Forms as well with no success. I'm afraid it may be out of commission for a while as I have too much else going on.

If you're interested in forking it and submitting a pull request, I'd be happy to test and accept the changes.

Cheers,

ben

[maplesyrupsucker]

It appears to be working fine for Gravity Forms v1.7.9

Just curious, is the validator simply checking to see if input == "" then showing the error if it's empty? I noticed that for email address fields it isn't checking to see if it's a valid email address, as no error shows up when I have "test" input within the field, where it should show the error unless it has a properly formatted test@test.com within it.

Great work on this plugin btw!

[bhays]

Correct, the validator is just doing the basics for now, so as long as there is some sort of input in the required field, it will pass.

Currently the script just looks at what Gravity Forms has marked as required, then does the same via JS. Unfortunately GF does not specify the field type, so setting a specific email validation check at this point isn't possible.

Other than that, glad it's working for you.

[landwire]

Hi Ben,
I am using GF 1.7.11 and the plugin does not work. I tried some debugging, but was a bit lost why it would not fire. I got it to work by using an actual form id as the selector in your .php file:

//"$('form').validate({".
"$('#gform_4').validate({". // so I use this on one form and it works
"debug: true,".

I am at a loss why it will not select the form with just ('form'). Any ideas? Maybe you have come across the issue before? If I find a fix I will post it here.
Would there be a way to actually change the selector to something like ('#gform_' + post[id]') I guess that should do the trick. I am not sure about the syntax here though!

[landwire]

OK. SOLVED. Hopefully! I am not a great coder, so not sure if there are any other implications. Forgot that I am in PHP land. Sometimes I get mixed up when PHP and Javascript get mixed. Solution as mentioned above:

Use:
"$('#gform_". $form['id'] . "').validate({".
instead of:
"$('form').validate({".

on line 80 in your PHP file. Hope that helps.
If you think it's ok, then maybe you could update the plugin. No idea how to do pull request etc on Github yet.
Sascha

[landwire]

And to pull in the text for the ErrorMeassages from the actual GF setting in the form editor use this example. I tinkered with other settings, but I guess people can see what is happening...

public static function add_page_script($form)
{
    self::log_debug('Adding page script to '.$form['id']);

    $script = "(function($){" .
        "var container;".
        // Find required elements and add class
        "$('.gfield_contains_required').each(function(i, e){".
            "$(e).find('input, select, textarea').attr('required', true);".
        "});".
        "$('#gform_". $form['id'] . "').validate({".
            "debug: false,".
            "errorElement: 'div',".
            "errorClass: 'gfield_error',".
            "errorPlacement: function(error, element){".
                "container = element.closest('.gfield');".
                // Only set container level error once
                //"if( ! container.hasClass('gf_js_error') ){".
                    "error.appendTo(container);".
                    //"container.addClass('gf_js_error');".
                //"}".
            "},";

            // must pull out messages for each input!!!
            $script2 = "messages: {";
            foreach ($form['fields'] as $field) { 
                        $field_name = 'input_' . $field['id']; // test
                        $field_errorMessage = "'" . $field['errorMessage'] . "',";
                        if ($field['errorMessage'] !== '')  {
                            $script2 = $script2 .
                            $field_name . ": " . $field_errorMessage;
                        }
            }
            $script2 = $script2 . "},";

            $script = $script . $script2 .
            "groups: getGroups(),".
            "focusCleanup: true,".
            // I removed the ugly highlighting that 
            //"highlight: function(element, errorClass, validClass) {".
                //"$(element).closest('.gfield').addClass(errorClass).removeClass(validClass);".
            //"},".
            //"unhighlight: function(element, errorClass, validClass) {".
                //"$(element).closest('.gfield').removeClass(errorClass).addClass(validClass);".
            //"},".
            "invalidHandler: function(event, validator) {".
                "gf_submitting_". $form['id'] . " = false;".
            "}".                
        "});".
    "})(jQuery);";


    GFFormDisplay::add_init_script($form['id'], 'gf_js_validate', GFFormDisplay::ON_PAGE_RENDER, $script);
    return $form;
}   

[bhays]

Thanks Sascha, I'll have a look at your code and try to get things merged in the coming weeks. Appreciate the contribution.

[landwire]

Cool. It seems to work fine for me, no errors yet. But then I have not tried every scenario possible and have not tried all fields. But it should hopefully all be ok.
S

On 21 Feb 2014, at 06:16, bhays notifications@github.com wrote:

Thanks Sascha, I'll have a look at your code and try to get things merged in the coming weeks. Appreciate the contribution.

—
Reply to this email directly or view it on GitHub.