From b3400ae1756b225d549ff4daa52b7c2849f0f9ec Mon Sep 17 00:00:00 2001 From: "vashbrightfire[bot]" Date: Tue, 8 Sep 2026 12:36:36 -0500 Subject: [PATCH] test: convert tui-pty terminal-safety comment-out skip to it.skip.each The commented-out import/case orphans exerciseTerminalOutputSafety for knip's all-exports scan (raw-tree PR CI failure on this branch, same root cause fixed on brightfire/ci in #181). it.skip.each keeps the case listed and the export referenced. No behavior change. --- src/tui/tui-pty-harness.e2e.test.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/tui/tui-pty-harness.e2e.test.ts b/src/tui/tui-pty-harness.e2e.test.ts index 37255a340679f..709d59ef18b12 100644 --- a/src/tui/tui-pty-harness.e2e.test.ts +++ b/src/tui/tui-pty-harness.e2e.test.ts @@ -8,7 +8,7 @@ import { disposeActiveTuiFixtures, exerciseFragmentedUnicodePrompt, exerciseNarrowTerminalRendering, - // exerciseTerminalOutputSafety, // Disabled: test case commented out for CI flakiness + exerciseTerminalOutputSafety, objectFieldEquals, readFixtureLog, startTuiFixture, @@ -728,10 +728,17 @@ describe.sequential("TUI PTY harness", () => { // prettier-ignore const terminalSafetyCases = [ ["renders long Unicode output and copy-safe URLs in narrow real PTY frames", () => exerciseNarrowTerminalRendering(startTuiFixture, STARTUP_TIMEOUT_MS)], - // ["sanitizes ANSI OSC and C1 payloads across real PTY display boundaries", () => exerciseTerminalOutputSafety(startTuiFixture, STARTUP_TIMEOUT_MS)], ] as const; it.each(terminalSafetyCases)("%s", async (_name, runCase) => runCase(), STARTUP_TEST_TIMEOUT_MS); + // Skipped (same CI flakiness as above) via it.skip.each so the case stays + // listed and the exerciseTerminalOutputSafety import stays live for knip's + // unused-export scan. + it.skip.each([ + "sanitizes ANSI OSC and C1 payloads across real PTY display boundaries", + () => exerciseTerminalOutputSafety(startTuiFixture, STARTUP_TIMEOUT_MS), + ])("%s", async (_name, runCase) => runCase(), STARTUP_TEST_TIMEOUT_MS); + // Disabled: flaky in CI — times out waiting for "monthly spending limit" under CPU contention. it.skip( "preserves xAI account limit errors in terminal output",