Deposits/Withdrawals In Pool Stats API Response

[ModernForays]

While looking into #6, I noticed two odd things about the pool stats returned from the API.

1. I don't see withdrawals populated on the daily aggregates for ETH or USDC. It seems possible (but unlikely) that nobody has withdrawn yet, so I believe this is in error.
2. The deposit amounts seem off:

This screenshot shows a daily ending balance 1 ETH higher than the starting balance, but with a 26 ETH deposit and no withdrawals. If traders had a 25 ETH winning day we would have heard about it in Discord, so this must be off.

[kappacappa]

@ModernForays deposits actually just count the user (LP) initiated deposits, not any trader pay ins. Same with withdrawals. Pool pay ins / payouts from/to traders are not explicitly included in the pool stats.

Still it is strange that 26 ETH appear on there. Seems the backend contract indexer is calculating deposits wrong.

[ModernForays]

@ModernForays deposits actually just count the user (LP) initiated deposits, not any trader pay ins. Same with withdrawals. Pool pay ins / payouts from/to traders are not explicitly included in the pool stats.

Cool, this was my understanding as well.

I just mean that if the pool-stats numbers are to believed (26 ETH deposited into pool, 0 ETH withdrawn from pool, starting balance of 6ish ETH and ending balance of 7ish ETH), traders would have won ~80% of 33 ETH present in pool that day and surely somebody would have mentioned that.