Task Description
Currently, our DataGridCheckboxCell component has been in WIP-status for way too long, while we are still seeing issues with misaligned Checkboxes in DataGrids in our applications.
In order to remedy both, the DataGridCheckboxCell component should be streamlined and un-WIPed. The Checkbox import should be removed, the cell should not render a Checkbox — developers should simply use it to place a Checkbox component inside and wire up all functionality with the checkbox directly. This is also much easier to retrofit in existing application views.
Our DataGridCheckboxCell component has been in WIP-status for too long and the alignment issues it was meant to solve remain unresolved.
During the implementation of the originally planned streamlining (removing the internal Checkbox render and having developers wire up a Checkbox child directly), it became clear that DataGridCell itself can and should provide the vertical centering that DataGridCheckboxCell was solely responsible for. A new verticalAlignment prop has been added to DataGridCell that overrides the parent DataGrid's cellVerticalAlignment per cell. With this in place, DataGridCheckboxCell has no remaining purpose and is removed entirely.
Sub-tasks
Task Description
Currently, ourDataGridCheckboxCellcomponent has been in WIP-status for way too long, while we are still seeing issues with misaligned Checkboxes in DataGrids in our applications.In order to remedy both, theDataGridCheckboxCellcomponent should be streamlined and un-WIPed. The Checkbox import should be removed, the cell should not render a Checkbox — developers should simply use it to place a Checkbox component inside and wire up all functionality with the checkbox directly. This is also much easier to retrofit in existing application views.Our
DataGridCheckboxCellcomponent has been in WIP-status for too long and the alignment issues it was meant to solve remain unresolved.During the implementation of the originally planned streamlining (removing the internal Checkbox render and having developers wire up a Checkbox child directly), it became clear that
DataGridCellitself can and should provide the vertical centering thatDataGridCheckboxCellwas solely responsible for. A newverticalAlignmentprop has been added toDataGridCellthat overrides the parentDataGrid'scellVerticalAlignmentper cell. With this in place,DataGridCheckboxCellhas no remaining purpose and is removed entirely.Sub-tasks
RemoveCheckboximportRemove all state-related propsMake sure the correct styles are included to position a manually added Checkbox child componentUpdate tests accordinglyUpdate stories and storybook descriptions accordinglyUn-WIP the component in storybookUpdate DataGrid stories to useDataGridCheckboxCellwhere applicableverticalAlignmentprop toDataGridCellDataGridCheckboxCellentirelyRelated Issues