Skip to content

[Task](context): streamline and finalize DataGridCheckboxCell component #1884

Description

@franzheidl

Task Description

Currently, our DataGridCheckboxCell component has been in WIP-status for way too long, while we are still seeing issues with misaligned Checkboxes in DataGrids in our applications.

In order to remedy both, the DataGridCheckboxCell component should be streamlined and un-WIPed. The Checkbox import should be removed, the cell should not render a Checkbox — developers should simply use it to place a Checkbox component inside and wire up all functionality with the checkbox directly. This is also much easier to retrofit in existing application views.

Our DataGridCheckboxCell component has been in WIP-status for too long and the alignment issues it was meant to solve remain unresolved.

During the implementation of the originally planned streamlining (removing the internal Checkbox render and having developers wire up a Checkbox child directly), it became clear that DataGridCell itself can and should provide the vertical centering that DataGridCheckboxCell was solely responsible for. A new verticalAlignment prop has been added to DataGridCell that overrides the parent DataGrid's cellVerticalAlignment per cell. With this in place, DataGridCheckboxCell has no remaining purpose and is removed entirely.

Sub-tasks

  • Remove Checkbox import
  • Remove all state-related props
  • Make sure the correct styles are included to position a manually added Checkbox child component
  • Update tests accordingly
  • Update stories and storybook descriptions accordingly
  • Un-WIP the component in storybook
  • Update DataGrid stories to use DataGridCheckboxCell where applicable
  • Add verticalAlignment prop to DataGridCell
  • Remove DataGridCheckboxCell entirely
  • Update all usages and stories accordingly
    Related Issues

Metadata

Metadata

Assignees

Labels

ui-componentsAll tasks related to juno-ui-components library

Type

Projects

Status
In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions