Unfortunately, the JNIGenerator is not using the same parameter names in the generated files as for example the ObjCppGenerator does.
This leads to issues reported by clang-tidy when having the readability-inconsistent-declaration-parameter-name check active.
The issue is in the following line generating the prototype, where the " " should have been " c_":
|
cppMarshal.fqParamType(p.ty) + " " + idCpp.local(p.ident) |
like for the body writer here:
|
cppMarshal.fqParamType(p.ty) + " c_" + idCpp.local(p.ident) |
You can use this search to compare the different generator implementations: https://github.com/search?q=repo%3Across-language-cpp%2Fdjinni-generator%20idCpp.local&type=code
I will potentially put up a PR to propose the fix.
Unfortunately, the
JNIGeneratoris not using the same parameter names in the generated files as for example theObjCppGeneratordoes.This leads to issues reported by
clang-tidywhen having thereadability-inconsistent-declaration-parameter-namecheck active.The issue is in the following line generating the prototype, where the
" "should have been" c_":djinni-generator/src/main/scala/djinni/JNIGenerator.scala
Line 373 in 719e0a7
like for the body writer here:
djinni-generator/src/main/scala/djinni/JNIGenerator.scala
Line 423 in 719e0a7
You can use this search to compare the different generator implementations: https://github.com/search?q=repo%3Across-language-cpp%2Fdjinni-generator%20idCpp.local&type=code
I will potentially put up a PR to propose the fix.