Skip to content

Commit bec2e7d

Browse files
mydeaclaude
andcommitted
test(e2e): Rename MCP auto apps; replace manual node-express-mcp-v2
Drop the `-auto` suffix now that auto-instrumentation is the default path: - `node-express-mcp-v1-auto` -> `node-express-mcp-v1` - `node-express-mcp-v2-auto` -> `node-express-mcp-v2`, replacing the previous manual-wrap app of that name (same assertions, now exercising the default auto path). Manual-wrap coverage remains via the cloudflare-mcp apps and the v1 `node-express*` apps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 858c4a4 commit bec2e7d

18 files changed

Lines changed: 19 additions & 365 deletions

File tree

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/instrument.mjs renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/instrument.mjs

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/package.json renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "node-express-mcp-v1-auto-app",
2+
"name": "node-express-mcp-v1-app",
33
"version": "1.0.0",
44
"private": true,
55
"scripts": {

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/playwright.config.mjs renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/playwright.config.mjs

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/src/app.ts renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/src/app.ts

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/src/mcp.ts renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/src/mcp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const mcpRouter = express.Router();
99
// Intentionally NOT wrapped with `wrapMcpServerWithSentry`: the `mcpServer` integration
1010
// auto-instruments the `McpServer` constructor, so spans must be produced anyway.
1111
const server = new McpServer({
12-
name: 'Echo-V1-Auto',
12+
name: 'Echo-V1',
1313
version: '1.0.0',
1414
});
1515

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/start-event-proxy.mjs renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/start-event-proxy.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
22

33
startEventProxyServer({
44
port: 3031,
5-
proxyServerName: 'node-express-mcp-v1-auto',
5+
proxyServerName: 'node-express-mcp-v1',
66
});

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/tests/mcp.test.ts renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/tests/mcp.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ test('auto-instruments a legacy MCP SDK v1 server (no manual wrap)', async ({ ba
99
const transport = new StreamableHTTPClientTransport(new URL(`${baseURL}/mcp`));
1010

1111
const client = new Client({
12-
name: 'test-client-v1-auto',
12+
name: 'test-client-v1',
1313
version: '1.0.0',
1414
});
1515

1616
const initializeSegmentPromise = waitForStreamedSpan(
17-
'node-express-mcp-v1-auto',
17+
'node-express-mcp-v1',
1818
segment => segment.is_segment && segment.name === 'initialize',
1919
);
2020

@@ -25,13 +25,13 @@ test('auto-instruments a legacy MCP SDK v1 server (no manual wrap)', async ({ ba
2525
expect(initializeSegment).toBeDefined();
2626
expect(getSpanOp(initializeSegment)).toEqual('mcp.server');
2727
expect(initializeSegment.attributes?.['mcp.method.name']?.value).toEqual('initialize');
28-
expect(initializeSegment.attributes?.['mcp.client.name']?.value).toEqual('test-client-v1-auto');
29-
expect(initializeSegment.attributes?.['mcp.server.name']?.value).toEqual('Echo-V1-Auto');
28+
expect(initializeSegment.attributes?.['mcp.client.name']?.value).toEqual('test-client-v1');
29+
expect(initializeSegment.attributes?.['mcp.server.name']?.value).toEqual('Echo-V1');
3030
});
3131

3232
await test.step('tool call', async () => {
3333
const toolSegmentPromise = waitForStreamedSpan(
34-
'node-express-mcp-v1-auto',
34+
'node-express-mcp-v1',
3535
segment => segment.is_segment && segment.name === 'tools/call echo',
3636
);
3737

@@ -60,7 +60,7 @@ test('auto-instruments a legacy MCP SDK v1 server (no manual wrap)', async ({ ba
6060

6161
await test.step('resource read', async () => {
6262
const resourceSegmentPromise = waitForStreamedSpan(
63-
'node-express-mcp-v1-auto',
63+
'node-express-mcp-v1',
6464
segment => segment.is_segment && segment.name === 'resources/read',
6565
);
6666

@@ -80,7 +80,7 @@ test('auto-instruments a legacy MCP SDK v1 server (no manual wrap)', async ({ ba
8080

8181
await test.step('error tool sets span status to error', async () => {
8282
const toolSegmentPromise = waitForStreamedSpan(
83-
'node-express-mcp-v1-auto',
83+
'node-express-mcp-v1',
8484
segment => segment.is_segment && segment.name === 'tools/call always-error',
8585
);
8686

dev-packages/e2e-tests/test-applications/node-express-mcp-v1-auto/tsconfig.json renamed to dev-packages/e2e-tests/test-applications/node-express-mcp-v1/tsconfig.json

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-express-mcp-v2-auto/instrument.mjs

Lines changed: 0 additions & 9 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/node-express-mcp-v2-auto/package.json

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)