Skip to content

Commit e847530

Browse files
committed
Update streamed mcp e2e span names and dedupe lockfile
1 parent 294216e commit e847530

2 files changed

Lines changed: 6 additions & 14 deletions

File tree

dev-packages/e2e-tests/test-applications/node-express-streaming/tests/mcp.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ test.skip('Should record streamed spans for mcp handlers', async ({ baseURL }) =
104104
return span.name === 'POST /messages' && getSpanOp(span) === 'http.server' && span.is_segment;
105105
});
106106
const resourceSpanPromise = waitForStreamedSpan('node-express-streaming', span => {
107-
return span.name === 'resources/read echo://foobar' && getSpanOp(span) === 'mcp.server' && span.is_segment;
107+
return span.name === 'resources/read' && getSpanOp(span) === 'mcp.server' && span.is_segment;
108108
});
109109

110110
const resourceResult = await client.readResource({
@@ -123,6 +123,7 @@ test.skip('Should record streamed spans for mcp handlers', async ({ baseURL }) =
123123
expect(resourceSpan).toBeDefined();
124124
expect(getSpanOp(resourceSpan)).toBe('mcp.server');
125125
expect(resourceSpan.attributes['mcp.method.name']?.value).toBe('resources/read');
126+
expect(resourceSpan.attributes['mcp.resource.uri']?.value).toBe('echo://foobar');
126127
});
127128

128129
await test.step('prompt handler', async () => {
@@ -244,7 +245,7 @@ test('Should record streamed spans for streamable HTTP transport (wrapper transp
244245
await test.step('resource handler', async () => {
245246
const resourceSpanPromise = waitForStreamedSpan('node-express-streaming', span => {
246247
return (
247-
span.name === 'resources/read echo://streamable-test' &&
248+
span.name === 'resources/read' &&
248249
getSpanOp(span) === 'mcp.server' &&
249250
String(span.attributes['mcp.transport']?.value).includes('StreamableHTTPServerTransport')
250251
);
@@ -262,6 +263,7 @@ test('Should record streamed spans for streamable HTTP transport (wrapper transp
262263
expect(resourceSpan).toBeDefined();
263264
expect(getSpanOp(resourceSpan)).toBe('mcp.server');
264265
expect(resourceSpan.attributes['mcp.method.name']?.value).toBe('resources/read');
266+
expect(resourceSpan.attributes['mcp.resource.uri']?.value).toBe('echo://streamable-test');
265267
});
266268

267269
await test.step('prompt handler', async () => {

yarn.lock

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15446,16 +15446,11 @@ events@^3.0.0, events@^3.2.0, events@^3.3.0:
1544615446
resolved "https://registry.yarnpkg.com/events/-/events-3.3.0.tgz#31a95ad0a924e2d2c419a813aeb2c4e878ea7400"
1544715447
integrity sha512-mQw+2fkQbALzQ7V0MY0IqdnXNOeTtP4r0lN9z7AAawCXgqea7bDii20AYrIBrFd/Hx0M2Ocz6S111CaFkUcb0Q==
1544815448

15449-
eventsource-parser@^3.0.0, eventsource-parser@^3.0.1:
15449+
eventsource-parser@^3.0.0, eventsource-parser@^3.0.1, eventsource-parser@^3.0.8:
1545015450
version "3.1.1"
1545115451
resolved "https://sfw.security.sentry.io/npm/eventsource-parser/-/eventsource-parser-3.1.1.tgz#b96cbb7dace4f3774f58a9e3b1ae9a4a524872e2"
1545215452
integrity sha512-EKN1vKAMcZ8MlYMpaNuxN6R9yakzH6uajHcHVTqWJzvu5pWw9DyhbP35HH8MVBQ+dZjAfDxk+A8NiR9KWaXiyQ==
1545315453

15454-
eventsource-parser@^3.0.8:
15455-
version "3.1.0"
15456-
resolved "https://registry.yarnpkg.com/eventsource-parser/-/eventsource-parser-3.1.0.tgz#4e198eb91cd333d0a8ddcc036502b3618a25f449"
15457-
integrity sha512-kJezFj9YFAMLeORyi7aCLxLbD5/qWMQnoMVlVPyHIll7lgRJCc3JVln9Vgl9nwQi0YkMnhdGTMNn7CkRRAptMg==
15458-
1545915454
eventsource@^3.0.2:
1546015455
version "3.0.7"
1546115456
resolved "https://sfw.security.sentry.io/npm/eventsource/-/eventsource-3.0.7.tgz#1157622e2f5377bb6aef2114372728ba0c156989"
@@ -28582,12 +28577,7 @@ zod@^3.23.8, zod@^3.24.1, zod@^3.25.32:
2858228577
resolved "https://registry.yarnpkg.com/zod/-/zod-3.25.76.tgz#26841c3f6fd22a6a2760e7ccb719179768471e34"
2858328578
integrity sha512-gzUt/qt81nXsFGKIFcC3YnfEAx5NkunCfnDlvuBSSFS02bcXu4Lmea0AFIUwbLWxWPx3d9p8S5QoaujKcNQxcQ==
2858428579

28585-
zod@^4.0.0:
28586-
version "4.3.6"
28587-
resolved "https://registry.yarnpkg.com/zod/-/zod-4.3.6.tgz#89c56e0aa7d2b05107d894412227087885ab112a"
28588-
integrity sha512-rftlrkhHZOcjDwkGlnUtZZkvaPHCsDATp4pGpuOOMDaTdDDXF91wuVDJoWoPsKX/3YPQ5fHuF3STjcYyKr+Qhg==
28589-
28590-
zod@^4.2.0:
28580+
zod@^4.0.0, zod@^4.2.0:
2859128581
version "4.4.3"
2859228582
resolved "https://sfw.security.sentry.io/npm/zod/-/zod-4.4.3.tgz#b680f172885d18bbebf21a834ea25e55a1bbf356"
2859328583
integrity sha512-ytENFjIJFl2UwYglde2jchW2Hwm4GJFLDiSXWdTrJQBIN9Fcyp7n4DhxJEiWNAJMV1/BqWfW/kkg71UDcHJyTQ==

0 commit comments

Comments
 (0)