From f219fe20a269c7a7f7f43fdff29d6084b27bd980 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sat, 26 Sep 2026 12:41:17 +0200 Subject: [PATCH] Run the tests on macOS and Windows, which were only ever cross-compiled The CI built for darwin/arm64 and windows/amd64 and ran on neither. A build is not a run: path handling, line endings and file semantics are where a Linux-only suite is quietly incomplete. Unlike the architecture lanes, this is not new ground -- poppler and pdfium are tested on both. It is ground the references hold and this repository did not. The coverage gate stays on ubuntu; these two lanes only run the tests. --- .github/workflows/ci.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20fad41..f0e9460 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -98,3 +98,23 @@ jobs: - run: sudo apt-get update && sudo apt-get install -y qemu-user-static - name: Test under qemu (${{ matrix.goarch }}) run: GOARCH=${{ matrix.goarch }} go test ${{ matrix.exec }} ./... + + # Cross-compiling for darwin and windows is not running there. poppler and + # pdfium are tested on both, so this is not new ground -- it is ground the + # references hold and this repository did not: path handling, line endings and + # file semantics are where a Linux-only suite is quietly incomplete. + # + # The coverage gate stays on ubuntu; these two lanes only run the tests. + os-matrix: + name: test (${{ matrix.os }}) + runs-on: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + os: [macos-latest, windows-latest] + steps: + - uses: actions/checkout@v7 + - uses: actions/setup-go@v7 + with: + go-version: "1.27.1" + - run: go test ./...