Skip to content

no check for receipt content #65

Description

@c-bg

Hi everyone,
First of all, thanks for this nice library.

I have two questions:

  1. If I see correctly, the connection Disconnect method only checks for whether the received next frame has the command RECEIPT, but does not check whether the received receipt's value is the same one as the sent receipt's one... shouldn't the code do that? Am I missing something here?

  2. Moreover, checking for whether the request contains a receipt and then checking the receipt is in almost all methods (e.g. in the connection Send method), but not in the Subscribe method. Why not? (note that this is slightly different than issue Support RECEIPT for SUBSCRIBE operations #40)

Thanks a lot for your answer in advance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions