From eda0882b50df94d4b3f9301009f7121316b5bb97 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Thu, 10 Sep 2026 10:52:05 +0200 Subject: [PATCH 1/2] Switch to latest version of key4hep-build workflow Co-Authored-By: Claude Sonnet 5 --- .github/workflows/key4hep.yml | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/.github/workflows/key4hep.yml b/.github/workflows/key4hep.yml index 304fb84..8c6e1d0 100644 --- a/.github/workflows/key4hep.yml +++ b/.github/workflows/key4hep.yml @@ -1,11 +1,16 @@ -name: Key4hep build +# Do not edit this file, it will be overwritten! +# The template file can be found in +# https://github.com/key4hep/key4hep-actions/blob/main/workflows/key4hep-build.yaml +name: Key4hep build on: push: branches: - - master + - master pull_request: workflow_dispatch: + schedule: + - cron: "16 4 * * *" concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -20,11 +25,25 @@ jobs: include: - build_type: nightly image: ubuntu24 + - build_type: nightly + image: ubuntu26 fail-fast: false runs-on: ubuntu-latest + container: + image: ghcr.io/key4hep/key4hep-images/${{ matrix.image }}-cvmfs + options: --privileged + volumes: + - /home/runner/.cache/ccache:/root/.cache/ccache + defaults: + run: + shell: bash steps: - - uses: actions/checkout@v4 - - uses: key4hep/key4hep-actions/key4hep-build@main - with: - build_type: ${{ matrix.build_type }} - image: ${{ matrix.image }} \ No newline at end of file + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 #v7.0.1 + - name: Mount CVMFS + run: /mount.sh + - uses: key4hep/key4hep-actions/cache-external-data@main + - uses: key4hep/key4hep-actions/key4hep-build@main + with: + build_type: ${{ matrix.build_type }} + image: ${{ matrix.image }} + stack: ${{ matrix.stack }} From a767ccf4e95a754eaa98b2d024ae142103b63e96 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Thu, 10 Sep 2026 12:11:44 +0200 Subject: [PATCH 2/2] Remove unused nHits counter in DebugTool::getAssociatedParticle gcc16 -Werror=unused-but-set-variable flags nHits as set but never read; it was incremented in the loop but had no other effect. Co-Authored-By: Claude Sonnet 5 --- include/DebugTool.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/DebugTool.h b/include/DebugTool.h index d6a79ee..ba299f9 100644 --- a/include/DebugTool.h +++ b/include/DebugTool.h @@ -87,7 +87,6 @@ class ConformalDebugger { // Temporarily store all mcparticles associated to this track std::vector particles; std::map particleHits; - double nHits = 0.; // Get the clusters from this track SharedKDClusters clusters = track->m_clusters; @@ -96,7 +95,6 @@ class ConformalDebugger { for (size_t itCluster = 0; itCluster < clusters.size(); itCluster++) { // Get the hit SKDCluster cluster = clusters[itCluster]; - nHits++; // If we already have hits on this particle, then just increment the counter if (particleHits.count(m_kdParticles[cluster]))