From 61c1fdacfbf0da9b64ddec72273b803ebf56d030 Mon Sep 17 00:00:00 2001 From: vinsentli Date: Tue, 13 Oct 2026 17:32:28 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E5=AE=9E=E7=8E=B0ComputeCommandEncoder::bi?= =?UTF-8?q?ndSamplerState(),=20bindImageTexture()?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/igl/opengl/ComputeCommandEncoder.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/igl/opengl/ComputeCommandEncoder.cpp b/src/igl/opengl/ComputeCommandEncoder.cpp index 4f0e457ed4..ea8e2d1ea9 100644 --- a/src/igl/opengl/ComputeCommandEncoder.cpp +++ b/src/igl/opengl/ComputeCommandEncoder.cpp @@ -133,18 +133,15 @@ void ComputeCommandEncoder::bindTexture(uint32_t index, ITexture* texture) { void ComputeCommandEncoder::bindImageTexture(uint32_t index, ITexture* texture, TextureFormat format) { - (void)index; - (void)texture; - (void)format; - - IGL_DEBUG_ASSERT_NOT_IMPLEMENTED(); + if (IGL_DEBUG_VERIFY(adapter_) && texture) { + adapter_->setImageTexture(texture, index, format); + } } void ComputeCommandEncoder::bindSamplerState(uint32_t index, ISamplerState* samplerState) { - (void)index; - (void)samplerState; - - IGL_DEBUG_ASSERT_NOT_IMPLEMENTED(); + if (IGL_DEBUG_VERIFY(adapter_) && samplerState) { + adapter_->setSamplerState(samplerState, index); + } } // NOLINTBEGIN(bugprone-easily-swappable-parameters) From a94fb09688d40f093736be66a9b716f919ff87fa Mon Sep 17 00:00:00 2001 From: vinsentli Date: Sat, 17 Oct 2026 17:01:53 +0800 Subject: [PATCH 2/2] IGL_PROFILER_FUNCTION(); --- src/igl/opengl/ComputeCommandEncoder.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/igl/opengl/ComputeCommandEncoder.cpp b/src/igl/opengl/ComputeCommandEncoder.cpp index ea8e2d1ea9..5131a23442 100644 --- a/src/igl/opengl/ComputeCommandEncoder.cpp +++ b/src/igl/opengl/ComputeCommandEncoder.cpp @@ -133,12 +133,14 @@ void ComputeCommandEncoder::bindTexture(uint32_t index, ITexture* texture) { void ComputeCommandEncoder::bindImageTexture(uint32_t index, ITexture* texture, TextureFormat format) { + IGL_PROFILER_FUNCTION(); if (IGL_DEBUG_VERIFY(adapter_) && texture) { adapter_->setImageTexture(texture, index, format); } } void ComputeCommandEncoder::bindSamplerState(uint32_t index, ISamplerState* samplerState) { + IGL_PROFILER_FUNCTION(); if (IGL_DEBUG_VERIFY(adapter_) && samplerState) { adapter_->setSamplerState(samplerState, index); }