v0.3.46 upgrade fails on Debian 12 due to retired NodeSource 18 repository

[Jdelg718]

Description

Upgrading a myNode x86_64 mini-PC from v0.3.37 to v0.3.46 repeatedly failed during mynode_post_upgrade.sh.

The v0.3.46 release files downloaded successfully and passed signature verification, but the post-upgrade process failed during apt-get update because the configured NodeSource 18 repository no longer provides a Bookworm Release file:

Err: https://deb.nodesource.com/node_18.x bookworm Release
  404 Not Found

E: The repository 'https://deb.nodesource.com/node_18.x bookworm Release'
no longer has a Release file.

The post-upgrade script retried five times and failed at the same point each time. The UI then displayed:

• “It appears a recent upgrade may not have fully completed.”
• A warning that Tor remained at v0.4.8.16

Environment

• myNode version shown after partial upgrade: 0.3.46
• Previous version: 0.3.37
• Device: x86_64 mini-PC
• OS: Debian 12 Bookworm
• Kernel: 6.1.0-16-amd64
• Architecture: x86_64

Confirmed workaround

The obsolete repository entries were commented out in:

/etc/apt/sources.list.d/nodesource.list

Afterward, sudo apt-get update completed successfully, and retrying the myNode upgrade completed successfully for us.

Suggested fix

The upgrade script should remove, disable, or replace the obsolete NodeSource 18 repository before running apt-get update. This likely affects other Debian 12 installations upgrading to v0.3.46.