Module snippet is broken

[jonathan-casarrubias]

When you use the module snippet since it shadows the Module name

import { Module } from '@onixjs/core';

and

export class Module {}

It generates issues, the class should be renamed to something else like

export class MyModule {}

to avoid shadowing issues.

Also, the lifecycle requires to return the method result or will stop the flow.

    lifecycle: async(appp, metadata, method): Promise<any> => {
        // before call
        const result = await method();
        // before call
        return result;
    }

[jonathan-casarrubias]

Also in the lifecycle it says "appp" instead of "app", anyway that is also deprecated... Not it passes a "models" method, which returns a specific model...

The final implementation it should be

lifecycle: async(models, message: OnixMessage , method): Promise<any> => {
        // before call
        const result = await method();
        // after call
        return result;
    }

I see why I generated the error in the datasource, this is the one that should have the OnixMessage instead of the datasource... :P lol

I just corrected the interfaces in the core I'm about to publish the fixes...

This should be the final implementation (Should also be implemented for component lifecycles)

lifecycle: async (
  models: ModelProvider,
  message: OnixMessage,
  method: OnixMethod
)  => {
  // before call
  const result = await method();
  // after call
  return result;
}

[raul26]

Fixed the issues.