From 67d9ed955334e841961457e194a7f9df55c5a3ec Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Bajpai Date: Wed, 5 Aug 2026 18:09:54 +0530 Subject: [PATCH] fix: resolve 4 bugs in AccountSafe --- frontend/src/components/PanicListener.tsx | 2 +- frontend/src/pages/ForgotPasswordPage.tsx | 2 +- frontend/src/services/securityService.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/components/PanicListener.tsx b/frontend/src/components/PanicListener.tsx index 80564ea..0e776ab 100644 --- a/frontend/src/components/PanicListener.tsx +++ b/frontend/src/components/PanicListener.tsx @@ -143,7 +143,7 @@ const PanicListener: React.FC = ({ onPanic }) => { if (currentKeys.length !== shortcut.length) return; // Sort and compare - const normalizedPressed = currentKeys.map(k => k.toLowerCase()).sort(); + const normalizedPressed = currentKeys.map(k => k.toLowerCase()).sort((a, b) => a - b); const normalizedShortcut = shortcut.map(k => k.toLowerCase()).sort(); const matches = normalizedPressed.every((key, index) => key === normalizedShortcut[index]); diff --git a/frontend/src/pages/ForgotPasswordPage.tsx b/frontend/src/pages/ForgotPasswordPage.tsx index 0b38b87..1c7894b 100644 --- a/frontend/src/pages/ForgotPasswordPage.tsx +++ b/frontend/src/pages/ForgotPasswordPage.tsx @@ -164,7 +164,7 @@ const ForgotPasswordPage: React.FC = () => { if (window.turnstile) { renderWidget(); - return undefined; + return; } else { const interval = setInterval(() => { if (window.turnstile) { diff --git a/frontend/src/services/securityService.ts b/frontend/src/services/securityService.ts index 3cd05a8..62176be 100644 --- a/frontend/src/services/securityService.ts +++ b/frontend/src/services/securityService.ts @@ -244,7 +244,7 @@ export const FORBIDDEN_SHORTCUTS: string[][] = [ * Check if a key combination is a forbidden browser shortcut */ export function isForbiddenShortcut(keys: string[]): boolean { - const normalizedKeys = keys.map(k => k.toLowerCase()).sort(); + const normalizedKeys = keys.map(k => k.toLowerCase()).sort((a, b) => a - b); return FORBIDDEN_SHORTCUTS.some(forbidden => { const normalizedForbidden = forbidden.map(k => k.toLowerCase()).sort();