Skip to content

App should display authentication error when 2FA state is stuck (LoginState.REQUIRE_2FA) #119

Description

@marklakata

Description:

When the authentication session is stuck in an incomplete 2FA state, the app fails silently to retrieve location data without informing the user what the problem is. This is especially problematic because:

Tags appear to import successfully
No location markers display
The only indication of the problem is buried in the debug logs
Users cannot troubleshoot or fix the issue

Expected Behavior:
When the app encounters findmy.errors.InvalidStateError: Invalid login state! Currently: LoginState.REQUIRE_2FA, it should display a clear user-facing error message explaining:

"Authentication incomplete: Two-factor verification required"
Guidance to log out and log back in through Settings
Suggestion to complete 2FA verification on a trusted device if needed

Actual Behavior:
The app silently fails with no user notification. Warnings appear only in logcat:

findmy.errors.InvalidStateError: Invalid login state! Currently: LoginState.REQUIRE_2FA but should be one of: (LoginState.LOGGED_IN,)
MapsActivity: No location is currently known for beaconId=..., so it cannot be drawn. Skipping.
MapsActivity: Found a beacon without locations! We can't draw such a beacon. Skipping...

Steps to Reproduce:

Import AirTags/items into OpenTagViewer
Authentication session gets stuck in REQUIRE_2FA state (possibly during login on Graphene OS or other privacy-hardened Android variants)
Attempt to view location data
No locations display with no error message shown to user

Environment:

Device: Android running Graphene OS
App Version: 1.0.5
Apple Account: Has 2FA enabled

Logs:
See attached log file for full stack trace. Key error (recurring):

findmy.errors.InvalidStateError: Invalid login state! Currently: LoginState.REQUIRE_2FA but should be one of: (LoginState.LOGGED_IN,)

Additional Notes:
The user already attempted logging out and logging back in, but the issue persists, suggesting this may be a session state bug rather than a simple re-auth issue.

( I had Claude write this up for me, but I agree with what it has generated. I will continue to try to fix my authentication problem by clearing the cache, etc, but I think notifying the user that something is wrong is extremely important, because I couldn't figure out why I didn't see any location information ).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    @appIssues regarding the OpenTagViewer Android appbugSomething isn't workingfixed in app 1.1.0Addressed by fixes shipping in the Android app 1.1.0 release

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions