Skip to content

Move context value creation to a user-overridable get_context method #104

Description

@gabubarks

Would it be possible to refactor this:

https://github.com/datadvance/DjangoChannelsGraphqlWs/blob/09a2ffdde45a1553abd09b5b3e595402b6e6c9b1/channels_graphql_ws/graphql_ws_consumer.py#L537-L542

into its own get_context method, which a user could override in a custom subclass of the GraphqlWsConsumer if they want to inject something into the context?

Currently I'm injecting my own fields by overriding _on_gql_start__subscribe and injecting the fields before passing it on to the super function, which seemed to be the least impactful place to do it. But I just found out that queries and mutations don't pass through that function, meaning I would have to copy-paste the entire _on_gql_start method from the source into my override class just to add my own fields to the context...

A get_context method would make this trivial and very user friendly. It would also mimic how graphene-django provides this functionality to its users:

https://github.com/graphql-python/graphene-django/blob/e950164c8ee2a9babf54a0c2d3da27194d7cfddc/graphene_django/views.py#L139-L140

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions