diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..1f77593 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the name used by search components +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..88ee687 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,5 @@ [test] -environment = "happy-dom" \ No newline at end of file +# Registers happy-dom globals (document, window) for React component tests. +# Bun reads only the bunfig.toml in the CWD, so this root config must point at +# the ui package's setup file for `bun test` to work from the repo root. +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..02792d3 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,11 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons render no visible text, so they must expose an accessible + * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). The label is + * always forwarded to the underlying element; if it is omitted on an icon-only + * button we fall back to a generic name so the control is never left unnamed, + * and warn in development so the authoring mistake is visible. */ export function Button({ children, @@ -34,13 +32,22 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) { + console.warn( + "Button: `iconOnly` buttons require an explicit `aria-label` describing the action (WCAG 2.2 SC 4.1.2).", + ) + } + + // A generic fallback keeps the control named for assistive technology, but it + // is not a meaningful name — always pass an explicit `aria-label`. + const resolvedAriaLabel = ariaLabel ?? (iconOnly ? "Button" : undefined) + return (