From 90dbfebb927bd0c4a93ca87c2bc83ef437691fde Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Mon, 17 Aug 2026 22:33:29 +0000
Subject: [PATCH] fix: repair cross-package test failures and clean type errors

Fix all failing tests and eliminate type errors across the monorepo:

- apps/web: rename stale useThrottle import to useDebounce and
  re-export as useSearchDebounce (packages/utils renamed the hook)
- packages/ui Button: apply aria-label to icon-only buttons with a
  string-children/'Button' fallback so iconOnly buttons always have an
  accessible name (WCAG 2.2 SC 4.1.2)
- packages/utils formatDate: emit an unpadded day (1/03/2024) using
  Intl formatToParts under en-AU, keeping a 4-digit year
- tsconfig: register bun-types so bun:test resolves under tsc --noEmit

bun run test: 13 pass / 0 fail. npx tsc --noEmit: clean.
---
 apps/web/src/lib/api.ts                      | 13 ++-------
 packages/ui/src/components/Button/Button.tsx | 17 +++++-------
 packages/utils/src/format/date.ts            | 29 ++++++++++----------
 tsconfig.json                                |  1 +
 4 files changed, 26 insertions(+), 34 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..56c1c04 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..3b5a38c 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -16,14 +16,6 @@ type Props = {
 
 /**
  * Button component.
- *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
  */
 export function Button({
   children,
@@ -34,13 +26,18 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  // Icon-only buttons render no visible text, so they must always carry an
+  // accessible name (WCAG 2.2 SC 4.1.2). Fall back to the string children if
+  // available, then to a generic label, so the button is never nameless.
+  const resolvedAriaLabel =
+    ariaLabel ?? (iconOnly ? (typeof children === "string" ? children : "Button") : undefined)
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..2ff9e52 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,22 @@
 /**
  * Date formatting utilities.
- *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
  */
+
+/** Formats as D/MM/YYYY for the en-AU locale — e.g. 1/03/2024, 15/06/2024. */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  // en-AU pads the day to 2 digits even when `day: "numeric"` is requested, so
+  // assemble the parts manually to get an unpadded day while keeping the
+  // unambiguous 4-digit year.
+  const parts = Object.fromEntries(
+    new Intl.DateTimeFormat("en-AU", {
+      day: "numeric",
+      month: "2-digit",
+      year: "numeric",
+    })
+      .formatToParts(date)
+      .map((p) => [p.type, p.value])
+  )
+  return `${Number(parts.day)}/${parts.month}/${parts.year}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]