From 8c66d095a0c1d126351d26122f513a3f7dc2d7a2 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Tue, 18 Aug 2026 00:26:58 +0000
Subject: [PATCH] fix: repair cross-package bugs failing the test suite
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- web: reconcile renamed hook — import useDebounce and re-export as
  useSearchDebounce (was importing the removed useThrottle)
- ui: apply aria-label on icon-only Button for WCAG 2.2 SC 4.1.2
- utils: format dates day-first without zero-padding (en-GB, day numeric)
- tsconfig: add bun-types so tsc resolves bun:test (pre-existing devDep)
---
 apps/web/src/lib/api.ts                      | 13 +++-------
 packages/ui/src/components/Button/Button.tsx | 26 +++++++++++++-------
 packages/utils/src/format/date.ts            | 16 +++++-------
 tsconfig.json                                |  1 +
 4 files changed, 27 insertions(+), 29 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..56c1c04 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..633e7f1 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,11 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must expose an accessible
+ * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). When `iconOnly`
+ * is set we always emit an `aria-label`, falling back to the string content of
+ * `children` and finally to a generic label, and warn in development so the
+ * missing label is caught at its source.
  */
 export function Button({
   children,
@@ -34,13 +32,23 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  let accessibleLabel = ariaLabel
+
+  if (iconOnly && !accessibleLabel) {
+    accessibleLabel = typeof children === "string" ? children : "Button"
+    if (process.env.NODE_ENV !== "production") {
+      console.warn(
+        "Button: `iconOnly` buttons require an explicit `aria-label` to provide an accessible name (WCAG 2.2 SC 4.1.2).",
+      )
+    }
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..7836a66 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,19 +1,15 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Australian date format is day-first with a non-padded day: 1/03/2024.
+ * The `en-AU` skeleton pads the day (`dd/MM/y` -> 01/03/2024), so `en-GB`
+ * is used here: it is also day-first but honours `day: 'numeric'`, giving
+ * a non-padded day alongside a 2-digit month and 4-digit year.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  return new Intl.DateTimeFormat("en-GB", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
   }).format(date)
 }
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]