diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..56c1c04 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app-facing name +export { useDebounce as useSearchDebounce } diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..523cbdc 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,9 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons render no visible text, so they must be given an + * `aria-label` describing the action (WCAG 2.2 SC 4.1.2). A development-time + * warning fires when one is omitted. */ export function Button({ children, @@ -34,13 +30,26 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + // Prefer an explicit aria-label; fall back to string children when the label + // was omitted. Icon-only buttons render no text, so they must always end up + // with a non-empty accessible name (WCAG 2.2 SC 4.1.2). + const rawLabel = ariaLabel ?? (typeof children === "string" ? children : undefined) + const derivedLabel = rawLabel?.trim() ? rawLabel : undefined + const accessibleName = iconOnly ? derivedLabel || "Button" : ariaLabel + + if (process.env.NODE_ENV !== "production" && iconOnly && !derivedLabel) { + console.warn( + "Button: `iconOnly` buttons require an `aria-label` describing the action " + + '(WCAG 2.2 SC 4.1.2). Falling back to "Button", which is not a meaningful name.', + ) + } + return (