From 0dda99cab2fc31fcc189684cf7b556be9d3f13c8 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Wed, 19 Aug 2026 16:32:55 +0000
Subject: [PATCH] fix: repair 5 failing tests and type errors across ui, utils
 and web

- api.ts: fix stale import of renamed hook (useThrottle -> useDebounce),
  keep useSearchDebounce alias the test expects
- bunfig.toml: register happy-dom via preload so document is defined in tests
- Button.tsx: forward aria-label so icon-only buttons have an accessible name
  (WCAG 2.2 SC 4.1.2), scoped to iconOnly to avoid Label-in-Name issues
- DataTable.tsx: fix stale-closure sort toggle with functional setState updater
- date.ts: format day without zero-padding via en-AU formatToParts
- tsconfig.json: add bun-types so bun:test resolves (no new dependency)
---
 apps/web/src/lib/api.ts                       | 12 +++------
 bunfig.toml                                   |  4 ++-
 packages/ui/src/components/Button/Button.tsx  | 25 ++++++++++++-------
 .../ui/src/components/DataTable/DataTable.tsx | 14 +++++------
 packages/utils/src/format/date.ts             | 25 +++++++++++--------
 tsconfig.json                                 |  1 +
 6 files changed, 43 insertions(+), 38 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..d9c4314 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..0e57100 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,4 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+# `environment = "happy-dom"` is Vitest/Jest syntax and is silently ignored by Bun.
+# The DOM must be registered via a preload script instead.
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..099b773 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,10 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must carry an explicit
+ * `aria-label` to expose an accessible name (WCAG 2.2 SC 4.1.2). Callers that
+ * omit it get a development warning and a generic fallback name, so the button
+ * is never left with no accessible name at all.
  */
 export function Button({
   children,
@@ -34,13 +31,23 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons have no visible text and require an explicit " +
+        "`aria-label` to provide an accessible name (WCAG 2.2 SC 4.1.2)."
+    )
+  }
+
+  const accessibleName = iconOnly
+    ? (ariaLabel ?? (typeof children === "string" ? children : "Button"))
+    : ariaLabel
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleName}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..7f8b1e7 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,22 +16,20 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
+ * The direction toggle uses the functional form of setState so it reads the
+ * current value rather than the one captured when the handler was created.
  *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * (Note: the `sortKey === key` guard still reads `sortKey` from the render
+ * closure. This is correct for all real user interaction, where each click is a
+ * separate render pass; it only matters for synthetic same-batch double clicks.)
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..3943c06 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,24 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Format a date as D/MM/YYYY for the Australian locale — e.g. `1/03/2024`.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Note: `Intl` ignores the *order* of the option keys and uses the locale's own
+ * pattern, so `en-AU` already yields day-first. The reason for building the
+ * string from `formatToParts` is that ICU's `en-AU` numeric skeleton zero-pads
+ * the day (`01/03/2024`). `dateStyle: "short"` drops the padding but also
+ * shortens the year to two digits, so it is not a substitute here.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+  const get = (type: string) => parts.find((p) => p.type === type)!.value
+  return `${Number(get("day"))}/${get("month")}/${get("year")}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]