uf2 combine: --offset representation

[Optoneer]

this was unexpected behaviour.

picotool v2.3.0: uf2 combine --offset produces different output for decimal and hexadecimal values although both represent the same offset.

Example:

picotool uf2 combine bootloader.uf2 app_a.uf2 test1.uf2 --offset 65536
picotool uf2 combine bootloader.uf2 app_a.uf2 test2.uf2 --offset 0x10000

test1.uf2 and test2.uf2 differ (cmp/sha256sum), and only the hexadecimal version boots correctly on RP2040.

[lurch]

I'm not familiar with the innards of picotool, but is it possible that the --offset parameter is always being interpreted as hexadecimal? https://github.com/raspberrypi/picotool/blob/develop/main.cpp#L1642
Does picotool uf2 combine bootloader.uf2 app_a.uf2 test3.uf2 --offset 10000 produce a "correct" UF2?

[Optoneer]

Looks like you are right. From a users point of view, any representation would be helpful. I ran into it while configuring my cmakelists file, when calculating the offset automatically.
The help output does not point to "only hex", what would have been useful in my case.

[lurch]

Would #353 help?

[Optoneer]

I think this is good enough to point someone to the right direction. Thank you.
Please feel free to close this issue.

[lurch]

This issue will self-destruct auto-close when the linked PR gets merged.