Crash when calling the project.write function

[ybbc]

If one xcodeproj references another, a crash occurs when calling the project.write function.
This happens in the PBXProjEncoder.sortProjectReferences function because lFile.name is nil, yet a forced unwrap is performed.

[dosubot]

Hi @ybbc! I'm Dosu and I'm helping the Tuist team.

This is a confirmed bug in PBXProjEncoder.swift at lines 491–492, where lFile.name! and rFile.name! force-unwrap a value that can legitimately be nil when a project references another .xcodeproj [1]. In that scenario, Xcode derives the display label from the path property instead of name.

There's an existing PR #1056 that fixes this by replacing the force-unwraps with safe fallbacks:

let lDisplay = lFile.name ?? lFile.path ?? ""
let rDisplay = rFile.name ?? rFile.path ?? ""

That PR hasn't been merged yet. As a workaround, you could ensure the referenced PBXFileElement has its name property set before calling write.

To reply, just mention @dosu.

---

Docs are dead. Just use Dosu.

[ybbc]

Thanks for the information. I hope PR #1056 can be merged soon.