Repository navigation
fix(readme): strip link-text markup to a fixed point - #9
Merged
Merged
Conversation
CodeQL (js/incomplete-multi-character-sanitization) flagged the single-pass tag strip: '<scr<b>ipt>' left '<script' behind. The text was only ever rendered as text, but it now reads as plain text too, with no angle brackets left.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
Clean against injection, CSP, two-views, input/focus and sync checks. The diff only touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL default setup, enabled today with the extended suite for actions, JavaScript/TypeScript and Python, raised one alert:
js/incomplete-multi-character-sanitizationatsrc/lib/readme.ts:62. A single pass of the tag-stripping regex over link text leaves<scriptbehind from<scr<b>ipt>.Was it exploitable? No. Segments only ever reach the page as text, through Astro's escaping and
textContent.What changes. The strip now repeats until nothing changes and then drops any stray angle brackets. A unit test covers the nested-tag case.
Checks. Unit tests 37 passed, e2e 43 passed.