Skip to content

fix: redeploy Pages after collectors and read the real candidates files - #64

Merged
kanywst merged 3 commits into
mainfrom
fix/pages-stale-and-candidates
Oct 18, 2026
Merged

kanywst merged 3 commits into
mainfrom
fix/pages-stale-and-candidates

Conversation

@kanywst

@kanywst kanywst commented Oct 18, 2026

Copy link
Copy Markdown
Member

The live site was stuck on the 2026-10-13 snapshot and showed 0 candidates for OAuth WG and OpenID. Both matter now because 0-draft/dev.to#13 (scheduled 2026-11-13) sends readers to the site and says it shows the latest run.

  • Stale site (deploy-pages.yml): daily-update.yml and weekly-digest.yml push with GITHUB_TOKEN, and those pushes never trigger push workflows. So Pages only redeployed on human commits; the last deploy was 2026-10-13 even though daily runs kept landing through 2026-10-17. Added a workflow_run trigger on both collectors, gated on the collector succeeding.
  • 0 candidates (web/src/lib/tracks.ts): topCandidates() read backlog.json (oauth-wg) and latest.json + top-<date>.json (openid), and neither file exists. Both tracks write data/normalized/candidates.json. Pointed both at it; the openid mapping is unchanged because candidates.json holds the same repo objects.

Verified with a local npm run build: the overview now reports Daily 2026-10-17 and Candidates 14 / 16 / 65 with top scores 10 / 110 / 21, where the live site shows 14 / 0 / 0. actionlint is clean.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc438d48-0af4-47c9-afdb-34826f7af2ae
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/workflows/deploy-pages.yml Outdated
@claude

claude Bot commented Oct 18, 2026

Copy link
Copy Markdown

The candidates.json reads in web/src/lib/tracks.ts match the files on main, and the new workflow_run trigger is least-privilege with pinned workflow names that match the collectors. There is one finding: the conclusion == 'success' gate in deploy-pages.yml skips the deploy when a single matrix track fails, even though the other tracks already pushed their data (inline comment). I didn't run the web build or the workflow.

@claude

claude Bot commented Oct 18, 2026

Copy link
Copy Markdown

No findings. The workflow_run names match the collector workflows, both collectors use fail-fast: false as the comment says, and the candidates.json shapes read in web/src/lib/tracks.ts match what the track scorers write.

@kanywst
kanywst merged commit 784f23d into main Oct 18, 2026
5 checks passed
@kanywst
kanywst deleted the fix/pages-stale-and-candidates branch October 18, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant