Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ethrpc/multicall.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ func (p *Provider) BatchCall(ctx context.Context, calls []multicall.Call, option

_, err := p.Do(ctx, calls_...)
if err != nil {
if err, ok := err.(BatchError); ok {
for i, err := range err.ErrorMap() {
if batchErr, ok := err.(BatchError); ok {
for i, err := range batchErr.ErrorMap() {
if err != nil {
if calls[i].AllowFailure {
if revertData, ok := revertDataFromError(err); ok {
Expand Down
34 changes: 34 additions & 0 deletions ethrpc/multicall_unit_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package ethrpc

import (
"context"
"errors"
"net/http"
"testing"

"github.com/0xsequence/ethkit/ethrpc/multicall"
)

type failingHTTPClient struct {
err error
}

func (c failingHTTPClient) Do(*http.Request) (*http.Response, error) {
return nil, c.err
}

func TestBatchCallPreservesTransportError(t *testing.T) {
transportErr := errors.New("transport unavailable")
provider, err := NewProvider(
"http://example.invalid",
WithHTTPClient(failingHTTPClient{err: transportErr}),
)
if err != nil {
t.Fatalf("NewProvider() error = %v", err)
}

_, _, err = provider.BatchCall(context.Background(), []multicall.Call{{}})
if !errors.Is(err, transportErr) {
t.Fatalf("BatchCall() error = %v, want it to wrap %v", err, transportErr)
}
}