[afffe18]

Branch feature/split-multiple-users, 18 commits against main (54 files, +2914 / −993).

Request money: split between several users

• Request money from several users at once and split it by factor, percentage or fixed amount; unset shares are calculated automatically and can be reset per person; optionally include your own share
• The simple form stays the default, splitting is enabled via the "Single / Group" toggle; negative automatic shares are marked with a warning icon

Amount fields: dot and comma

• New DecimalInput component replaces type="number": accepts both dot and comma as decimal separator; at most 4 decimal places are shown

Keycloak / LDAP

• Old LDAP usernames ("firstname.lastname") are replaced with the Keycloak display name ("Firstname Lastname") on Keycloak login and once at server start; other names are left unchanged
• Admin rights (LABEATS_ADMIN) are synced with the user's groups on every Keycloak login; without a groups claim the stored value is kept

Sign-out after update

• Every build gets a SESSION_BUILD_ID; sessions from older builds are rejected, so every container update signs all users out once. Restarting the same image signs nobody out.

Group orders

• Individual items are only reserved (transaction type 4, "reserved purchase") and charged when the order is settled; they can be cancelled until the order closes. Reservations count towards the balance check for users who are not creditworthy.
• Shopper: "I'm going shopping" / sign off, set automatically when the order closes or is settled or by a new button; only one Person can be the shopper but you can take it from some else.
• Category filter for the order window (admins and shopper)
• Reworked settlement: adjustable prices for individual items, "Total / group items only" toggle, separate button; admins can always revert a settlement, the person who settled it for 2 h
• Recurring orders: "hours before" (ordersStartsAt, default 72 h)

Deposit

• Items can have a deposit amount; the buy tab shows a separate "+ deposit" button for it, booked as a regular purchase without category markups
• Deposit as a column in the inventory; inventory sortable by name, price, deposit and account

Statistics

• Profile: tiles for ranking, total spending, procurement, weekly/monthly average, deposit and top 3 items
• New admin page "Statistics" with totals only: revenue, active users, deposit, outstanding balances, overdrafts, best-selling items

Notification dot

• Red dot on the account tab (on mobile on the menu icon) when someone has collected money from you; it disappears once the account page has been opened

Minor UI fixes

• Top-up button in the header uses the nav color,
• filter buttons in the buy tab are consistent and persistent,
• the creditworthy checkbox in the user popup resets when switching users
• changed & more consistant grey shades

Cleanup and booking bugs

• Security: removed user.getCtx, which returned the LDAP bind password without login
• Undo now also books the item price/deposit back from the clearing account
• Undo, transfers, closing/reverting group orders are protected against double execution
• Fees without a target clearing account are rejected instead of being lost; no negative prices when closing a group order
• LDAP user data no longer logged, cron errors are logged; dead code and debug logs removed; npm audit fix
• README: instructions for local development

Deployment notes

• 4 migrations, applied automatically via prisma migrate deploy in the entrypoint:
  • add_orders_starts_at_to_template: new column, default 72
  • add_item_deposit: new column, default 0
  • add_grouporder_shopper_and_filter: rebuilds the GroupOrder table and backfills the shopper of closed orders with the recipient of the settlement.
  • add_user_retractions_seen_at: marks all existing money collections as seen so nobody sees a stale red dot after the update
• All users are signed out once after deployment (new build ID).
• src/instrumentation.ts renames old LDAP usernames once at server start. This is transitional code and can be removed (together with syncKeycloakNames in src/server/syncKeycloakNames.ts) once all accounts have been migrated. Renaming on login is not affected.
• Individual items that were still charged directly at purchase before the update are booked back from the clearing account when a settlement is reverted, so old orders remain revertible.
• The entrypoint script does not abort if a migration fails: the app still starts, but with an incompletely migrated schema. Check the output of prisma migrate deploy in the container log after deploying.

Summary by CodeRabbit

• New Features
  • Added deposit purchases, with deposits shown in item forms and inventory.
  • Group orders now support shopper sign-up, category filters, quantity selection, individual purchases, and more detailed cost splitting.
  • Added group money requests with factor-, percentage-, or amount-based splits.
  • Added admin statistics and expanded personal purchase statistics, including rankings and averages.
  • Added searchable, sortable user balances and sortable inventory columns.
  • Added notices for unseen money retractions.
• Improvements
  • Decimal fields now accept either a comma or a period as the decimal separator.
  • Group orders can be reverted by administrators or by the person who closed them within two hours.
• Documentation
  • Updated setup instructions and clarified database path handling.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: ba7d0833-2e03-43bb-a7cf-0d25139ff8d8

Commits

Reviewing files that changed from the base of the PR and between bb83db7 and 522b76a.

Files ignored due to path filters: 1

• package-lock.json is excluded by !**/package-lock.json

Files selected for processing: 61

• .env.example
• README.md
• eslint.config.mts
• next.config.mjs
• prisma/migrations/20261017200000_add_orders_starts_at_to_template/migration.sql
• prisma/migrations/20261018121500_add_item_deposit/migration.sql
• prisma/migrations/20261018140000_add_grouporder_shopper_and_filter/migration.sql
• prisma/migrations/20261018160000_add_user_retractions_seen_at/migration.sql
• prisma/schema.prisma
• scripts/screenshots/seed.ts
• src/components/FormElements/GroupOrderDetailView.tsx
• src/components/FormElements/GroupOrderSplit.tsx
• src/components/Forms/CategoryForm.tsx
• src/components/Forms/GrouporderTemplateForm.tsx
• src/components/Forms/ItemForm.tsx
• src/components/General/BuyItemCard.tsx
• src/components/General/BuyItemCardBig.tsx
• src/components/General/DecimalInput.tsx
• src/components/Layout/Header.tsx
• src/components/Layout/Layout.tsx
• src/components/PageComponents/GetMoney.tsx
• src/components/PageComponents/InventoryOverview.tsx
• src/components/PageComponents/RankingCard.tsx
• src/components/PageComponents/SendMoney.tsx
• src/components/PageComponents/TransactionList.tsx
• src/components/PageComponents/UserOverview.tsx
• src/helper/dataProcessing.ts
• src/helper/generalFunctions.test.ts
• src/helper/generalFunctions.ts
• src/helper/globalTypes.ts
• src/instrumentation.ts
• src/pages/account.tsx
• src/pages/admin/clearingAccounts.tsx
• src/pages/admin/stats.tsx
• src/pages/all-users.tsx
• src/pages/api/cron/trigger.ts
• src/pages/buy.tsx
• src/pages/grouporders/history.tsx
• src/pages/grouporders/index.tsx
• src/pages/me/index.tsx
• src/pages/split.tsx
• src/pages/top-up.tsx
• src/proxy.ts
• src/server/api/routers/categories.ts
• src/server/api/routers/groupOrders.ts
• src/server/api/routers/items.ts
• src/server/api/routers/transactions.ts
• src/server/api/routers/user.ts
• src/server/auth.ts
• src/server/db.ts
• src/server/helper/dbCallHelper.ts
• src/server/helper/statistics.test.ts
• src/server/helper/statistics.ts
• src/server/ldap.ts
• src/server/sessionBuild.test.ts
• src/server/sessionBuild.ts
• src/server/syncKeycloakAdmin.test.ts
• src/server/syncKeycloakAdmin.ts
• src/server/syncKeycloakNames.test.ts
• src/server/syncKeycloakNames.ts
• src/styles/globals.css

+---------------------------------+
| My GPU is bigger than your GPU. |
+---------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[13Bytes]

Hey,
danke für die Erweiterungen!

Ein paar Dinge:

1. Category fees can disappear before settlement — P1

The new flow delays charging a reserved item until the group order is settled. To calculate its fees later, settlement reads the categories associated with that purchase.

However, the category relationship can point to only one purchase. Buying another item with the same category moves that relationship to the newer purchase.

For example:

1. Alice reserves an item with a €0.50 category fee.
2. Bob reserves another item using that category.
3. The category association moves from Alice’s reservation to Bob’s.
4. At settlement, Alice’s reservation no longer has the category information needed to charge her fee.
   An ordinary purchase can also displace the association. The result is missing charges and too little money credited to the clearing account. Previously, fees were calculated immediately, before a later purchase could change the relationship.

Suggested fix: save the applicable fees and their destination accounts separately for every reservation, so subsequent purchases cannot change them.

2. A reservation can arrive after the order has settled — P2

Checking whether an order is open and creating the reservation happen separately. Another request can close and settle the order between those steps.

For example:

1. Alice clicks to reserve an item; the server checks that the order is open.
2. The shopper closes and settles the order.
3. Alice’s request resumes and creates the reservation without checking again.
   That reservation missed settlement, but cancellation is now blocked because the order is closed. Its amount can remain reserved against Alice’s available balance, reducing what she can spend or transfer.

Suggested fix: make checking the order’s state and creating the reservation one coordinated operation that cannot race with closure or settlement.

3. Editing a category can empty an order’s item list — P2

Editing a category creates a replacement category with a new ID and moves its items to that replacement. An existing group order’s filter still points to the old ID.

For example, an order is filtered to “Drinks.” An admin edits that category. All drinks now belong to its replacement, while the order continues filtering by the old category. Consequently, no items match, and the old category also disappears from the selector.

This disrupts ordering until the shopper or an admin resets the filter; it does not delete the items.

Suggested fix: update affected order filters when replacing a category, or have filters refer to a category identity that remains stable across edits.

[13Bytes]

Do we need a dedicated deposit or would a bottle deposit item be good enough?

[13Bytes]

would it make sense to add a default to the GroupOrderTemplate as well?

[13Bytes]

[13Bytes]

can we harmonize/combine this component with the one that handels the group order multi-user money split?