Repository navigation
Conversation
Different runtime libraries implement intrinsics differently so the paths produced on linux, mac and windows can differ enough that a "perfectly" selected max Xi will exhaust all reactants on one machine but come up just short on others. Bumping the Xi max in the tests gets us past that.
We get warnings from compiler on Windows that dscal and idamax undergo aggressive optimization. In reality, both of those routines are better written using intrinsics or standard features. NOTE: The idamax does, ever so slightly, change the outputs so that the snapshot tests should fail. I cannot say exactly why, but on my machine the differences in ymp/heatsw.6p are less than 1e-15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR transitions all Fortran sources to (near) modern Fortran free-form style and transitions the project to the Meson build system.
Also included is the
presmxbump from 10000 to 90000 bar.