DOCS: Describe granting native library access - #563
Draft
oleksandrlazarenko-pi wants to merge 1 commit into
Draft
Conversation
Documents --enable-native-access for classpath and module path setups, following the module names added in pipeline-java for #476.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation half of #476.
On-premise device detection loads its native library through
System.load, whichrecent JDKs treat as a restricted method and will eventually block
(JEP 472). The load happens in
LibLoader, which livesin
pipeline.engines.fiftyone, so the permission is granted against that packagerather than anything in this repository.
Adds a Native library access section to the README covering:
--enable-native-access=ALL-UNNAMED), which is the usual setupand stays unchanged;
(
--enable-native-access=fiftyone.pipeline.engines.fiftyone), enabled by the modulenames added in 51Degrees/pipeline-java;
that apply on the module path.
No code changes. The device detection packages remain unnamed modules and need none -
unnamed modules can read named ones.
Depends on the companion pipeline-java PR, which adds the README section this one links
to; merge that first.