Skip to content

chore(build): drop CommonJS (CJS) build - #1310

Open
ghiscoding wants to merge 1 commit into
next-v6from
chore/drop-cjs
Open

ghiscoding wants to merge 1 commit into
next-v6from
chore/drop-cjs

Conversation

@ghiscoding

Copy link
Copy Markdown
Collaborator

Summary

drop CommonJS (CJS) build since it's no longer necessary and NodeJS now allows to require(esm) anyway

Why

to decrease the size of our lib being published to npm

Validations

run a prod build and also ran dev watch server

AI / LLM assistance

  • AI / LLM assistance used:
    • No
    • Yes
  • If Yes:
    • which tool/model:
    • how was it used:

Checklist

  • The changes are limited to only one scope (if not please explain why in the comments above).
  • Tests were added or updated where appropriate.
  • Documentation was updated where appropriate.

@ghiscoding

Copy link
Copy Markdown
Collaborator Author

@6pac small PR to drop CJS build, I'll do a follow-up PR to remove the dist/ folder in another PR.

Side note, I guess you could start rebasing the drop SortableJS if you want to start with that.
Cheers

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant