fix: Register root utility submodules in _import_structure - #454
Open
richaguptaa17 wants to merge 1 commit into
Open
fix: Register root utility submodules in _import_structure #454richaguptaa17 wants to merge 1 commit into
richaguptaa17 wants to merge 1 commit into
Conversation
… lazy loading AttributeError Register root utility submodules (`max_logging`, `max_utils`, `pyconfig`, `maxdiffusion_utils`, `aot_cache`, `multihost_dataloading`, `train_utils`, `tpu_utils`, `checkpointing`, `common_types`) in `_import_structure` in `src/maxdiffusion/__init__.py`. During `_LazyModule` lazy module resolution, submodules importing top-level utility modules like `max_logging` via `from maxdiffusion import max_logging` triggered an `AttributeError` because these utility submodules were not registered in `_import_structure`. Python caught this `AttributeError` during submodule loading and raised `ImportError: cannot import name 'FlaxAutoencoderKL' from 'maxdiffusion.models'`. Adding these utility submodules to `_import_structure` resolves root attribute lookups lazily, allowing imports of `FlaxAutoencoderKL`, `FlaxUNet2DConditionModel`, and `BaseStableDiffusionCheckpointer` to succeed. Fixes AI-Hypercomputer#453
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
max_logging,max_utils,pyconfig,maxdiffusion_utils,aot_cache,multihost_dataloading,train_utils,tpu_utils,checkpointing,common_types) in_import_structureinsrc/maxdiffusion/__init__.py.src/maxdiffusion/tests/models_import_test.pyto verify lazy resolution forFlaxAutoencoderKL,FlaxUNet2DConditionModel,BaseStableDiffusionCheckpointer, and top-level utility imports (max_logging,max_utils,pyconfig,maxdiffusion_utils).Issues Fixed
Fixes #453