Skip to content

pathwaysutils: Add elastic_slices validation to JobSet generator. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pathwaysutils: Add elastic_slices validation to JobSet generator. #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pathwaysutils/experimental/gke/jobset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ def __init__(
self._labels = dict(labels) if labels else {}
self._annotations = dict(annotations) if annotations else {}

if elastic_slices > num_slices:
raise ValueError(
f"elastic_slices ({elastic_slices}) cannot be greater than "
f"num_slices ({num_slices})"
)
tpu_version = MACHINE_TYPE_TO_TPU_VERSION_MAP.get(tpu_type.lower())
if not tpu_version:
raise ValueError(f"Unsupported TPU type: {tpu_type}")
Expand Down
Loading