fix: wait out SQLite busy on concurrent asset upserts - #329
Open
OrdinarySF wants to merge 1 commit into
Open
OrdinarySF wants to merge 1 commit into
OrdinarySF wants to merge 1 commit into
Conversation
Deep mode fires many create_asset calls at once. UpsertAssets used a DEFERRED transaction (SELECT then INSERT) on a 25-connection pool, so writers hit SQLITE_BUSY immediately and returned "database is locked" in a few milliseconds instead of waiting. Open SQLite with _txlock=immediate and a 30s busy timeout, shrink the pool, and retry locked upserts. Add a 32-way concurrent upsert test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #328
Deep mode fires many
create_assetcalls in the same turn. Those writes hit SQLitedatabase is lockedin 4–26ms, so_busy_timeout=5000never actually waited.This is not a missing pool.
configureDBPoolalready setsMaxOpenConns=25. SQLite still allows only one writer.UpsertAssetsuses a DEFERRED transaction (SELECTthenINSERT). Parallel deferred txs deadlock on the write upgrade and SQLite returnsSQLITE_BUSYimmediately.Changes
_txlock=immediateand_busy_timeout=30000UpsertAssetsa few times ondatabase is lockedsqliteOpenDSN()for conversations and knowledge DBsTest plan
TestUpsertAssetsConcurrentDoesNotReturnLocked— 32 goroutines upsert distinct hostsgo test ./internal/database -run 'Asset|Upsert'