arm64: dts: ghana: Configure Venice RMI/TSI devs#277
Open
amd-knieman wants to merge 1 commit into
Open
Conversation
All other SP7 platforms configured the static I3C addresses for SBRMI and SBTSI I3C devices. Without this, P1 SBRMI and SBTSI will fail to bind the driver. ``` i3c_device_match_id: manuf 0x0, part 0x0, inst 0x0, ext_info 0x118 sbtsi_i3c 4-118: SBTSI: PID: 118 sbtsi_i3c 4-118: register sbtsi-9 device APML: Registered SBTSI device at address 0x9 ... i3c_device_match_id: manuf 0x0, part 0x100, inst 0x0, ext_info 0x118 sbtsi_i3c 5-1000118: SBTSI: PID: 1000118 sysfs: cannot create duplicate filename '/class/misc/sbtsi-9' CPU: 2 PID: 30983 Comm: s0-state-mgr Tainted: G O 6.6.92-dirty-9baaae4348bb-g9baaae4348bb #1 Hardware name: AMD Ghana PRB (DT) Call trace: dump_backtrace+0xa0/0x11c show_stack+0x18/0x24 dump_stack_lvl+0x48/0x60 dump_stack+0x18/0x24 sysfs_warn_dup+0x64/0x80 sysfs_do_create_link_sd+0xf0/0xf8 sysfs_create_link+0x20/0x40 device_add+0x2fc/0x7ec device_create_groups_vargs+0xe0/0x134 device_create_with_groups+0x58/0x84 misc_register+0xd8/0x188 create_misc_tsi_device+0x78/0xac sbtsi_i3c_probe+0x140/0x214 i3c_device_probe+0x18/0x24 really_probe+0x160/0x3d8 __driver_probe_device+0x88/0x170 device_driver_attach+0x48/0xac bind_store+0x7c/0xd0 drv_attr_store+0x24/0x38 sysfs_kf_write+0x44/0x54 kernfs_fop_write_iter+0x134/0x1e0 vfs_write+0x190/0x314 ksys_write+0x70/0x108 __arm64_sys_write+0x1c/0x28 invoke_syscall.constprop.0+0x5c/0x100 do_el0_svc+0xa8/0xc8 el0_svc+0x40/0x128 el0t_64_sync_handler+0x120/0x12c el0t_64_sync+0x190/0x194 sbtsi_i3c: probe of 5-1000118 failed with error -17 ``` Statically set the I3C addresses for SBRMI/SBTSI for Ghana as well. Tested: Driver binding for Ghana now succeeds for P1 SBRMI and SBTSI. Signed-off-by: Kyle Nieman <Kyle.Nieman@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other SP7 platforms configured the static I3C addresses for SBRMI and SBTSI I3C devices. Without this, P1 SBRMI and SBTSI will fail to bind the driver.
Statically set the I3C addresses for SBRMI/SBTSI for Ghana as well.
Tested:
Driver binding for Ghana now succeeds for P1 SBRMI and SBTSI.