Repository navigation
fix: failed image deletion dialog displays windows path (#1657) - #1672
Prakhar1808 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Path component extraction frontend/src/hooks/useDeleteImages.ts |
Failed paths are split on either / or \ before the dialog displays the final path component. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related issues
Suggested labels: TypeScript/JavaScript
Suggested reviewers: takitxt
Merge Risk: 
Minimal · up to 86b9a
-
The filename display fix matches the requested Windows and POSIX path behavior and is ready to merge.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the change: a fix so the failed image deletion dialog no longer shows a Windows path. The raw summary confirms the file path split now handles both
/and\, which matches the title. The title is short, specific, and matches linked issue#1657. It does not cover every detail, which is acceptable.
Full details: Linked Issues check
-
Explanation
The change satisfies
#1657. Infrontend/src/hooks/useDeleteImages.ts, the failed-path filename extraction now usespath.split(/[/\\]/).pop(). This extracts the final filename for both forward-slash and Windows backslash paths in the failed-deletion dialog.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the path with care,
Finds the filename hiding there.
A slash, a backslash, either way,
The dialog shows the name today.
The long paths hop out of sight,
And filenames land just right.
Comment @coderabbitai help to get the list of available commands.
Addressed Issues:
Fixes #1657
the path now separates at both path types
the fix
Screenshots/Recordings:
check the issue #1657 to understand and look at screenshots
AI Usage Disclosure:
Checklist
Summary by CodeRabbit