Conversation
Remediation for Darkmoon finding vuln_959dd9 (xss_stored, high).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Severity: high | Category: xss_stored
Endpoint:
http://172.19.0.3:8080/#/search?q=The search-result component wrapped user input with
DomSanitizer.bypassSecurityTrustHtml, enabling DOM/reflected XSS via the search query and product descriptions.Fix
Removes the
bypassSecurityTrustHtmlcalls so Angular's built-in contextual output encoding applies.Files changed:
frontend/src/app/search-result/search-result.component.tsValidation intent
Manual verification that the documented exploit path no longer succeeds, plus the project's existing test suite. This PR is intended for human review and is never auto-merged.
Why this is a draft
Template bindings may need to move from
[innerHTML]to interpolation for full coverage and type consistency; opened as draft pending a frontend review and build.AI-assistance disclosure: this remediation was generated with AI assistance (Darkmoon remediation agent) and requires human code review before merge. No overclaim is intended.
Darkmoon finding reference: vuln_959dd9.