Update orbit file search to return an ANX-inclusive result - #72
Update orbit file search to return an ANX-inclusive result#72forrestfwilliams wants to merge 2 commits into
Conversation
|
Two concerns:
|
Here's the reason given for S1Reader in this comment:
I believe he's referring to this issue resolved by this PR (with more discussion).
Yeah, that's a problem for scene name -> download for sure. |
|
s1_reader has an implementation to deal with the RESORB issue, but that's a bit more complicated and bespoke than the simple 80-20 use case |
The s1-reader implementation is pretty much a drop-in replacement that gets you the anx crossing time included: - orbit_file = s1_orbits.fetch_for_scene(scene_name)
+ orbit_file = s1_reader.s1_orbit.retrieve_orbit_file(scene_name, orbit_dir='.', concatenate=True)I personally would be fine closing this and the corresponding issue as a "won't do" and pointing people to the s1-reader implementation for ISCE3-based workflows. |
Notable potential users of this API (the OPERA project and other users working with ISCE3) need their orbit files to include the ascending node crossing time to perform certain data corrections. The ascending node crossing time is the time at which the satellite platform crosses the equator from the southern to northern hemisphere. See here for the s1-reader implementation of this requirement.
In the absence of any other conflicting date range requirements, we should make returning an orbit that includes the ascending node crossing time a base requirement for the API.