Repository navigation
Fix out-of-bounds rvec indices in atmosphericDrag error message - #1620
Merged
Merged
Conversation
carlo98
added a commit
to carlo98/basilisk
that referenced
this pull request
Oct 16, 2026
carlo98
force-pushed
the
hotfix/atmosphericDrag_error_msg
branch
from
October 16, 2026 15:19
9bb32f5 to
c7e679c
Compare
carlo98
marked this pull request as ready for review
October 16, 2026 15:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
schaubh
approved these changes
Oct 17, 2026
schaubh
force-pushed
the
hotfix/atmosphericDrag_error_msg
branch
from
October 17, 2026 03:09
c7e679c to
ea5a446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
atmosphericDrag()insrc/architecture/utilities/orbitalMotion.creceived a position with a non-positive altitude, itsMSG_ERRORmessage printedrvec[1], rvec[2], rvec[3]. That showed the y and z components followed byrvec[3], one element past the end of the 3-element position vector. The printed position was wrong, and the read was out of bounds.Verification
No automated test was added. The existing Python tests in
src/tests/test_orbitalMotion.pycover the pure-PythonorbitalMotion.py, and the CatmosphericDrag()is not exposed through SWIG.Documentation
docs/source/Support/bskKnownIssues.rst.Future work
None.